feat: Deprecate embedded browser and import console (#12460)

This feature also changes the default port where
the browser is running, now the port has moved
to 9001 and it can be configured with

```
--console-address ":9001"
```

internal/config/errors.go

@@ -20,9 +20,9 @@ package config
 // UI errors
 var (
 	ErrInvalidBrowserValue = newErrFn(
-		"Invalid browser value",
+		"Invalid console value",
 		"Please check the passed value",
-		"Browser can only accept `on` and `off` values. To disable web browser access, set this value to `off`",
+		"Environment can only accept `on` and `off` values. To disable Console access, set this value to `off`",
 	)
 
 	ErrInvalidFSOSyncValue = newErrFn(

internal/config/identity/openid/help.go

@@ -31,6 +31,11 @@ var (
 			Key:         ClientID,
 			Description: `unique public identifier for apps e.g. "292085223830.apps.googleusercontent.com"`,
 			Type:        "string",
+		},
+		config.HelpKV{
+			Key:         ClientSecret,
+			Description: `secret for the unique public identifier for apps e.g.`,
+			Type:        "string",
 			Optional:    true,
 		},
 		config.HelpKV{

internal/config/identity/openid/jwt.go

@@ -48,6 +48,7 @@ type Config struct {
 	ClaimName    string    `json:"claimName,omitempty"`
 	DiscoveryDoc DiscoveryDoc
 	ClientID     string
+	ClientSecret string
 	publicKeys   map[string]crypto.PublicKey
 	transport    *http.Transport
 	closeRespFn  func(io.ReadCloser)
@@ -220,19 +221,21 @@ func (p *JWT) ID() ID {
 
 // OpenID keys and envs.
 const (
-	JwksURL     = "jwks_url"
-	ConfigURL   = "config_url"
-	ClaimName   = "claim_name"
-	ClaimPrefix = "claim_prefix"
-	ClientID    = "client_id"
-	Scopes      = "scopes"
+	JwksURL      = "jwks_url"
+	ConfigURL    = "config_url"
+	ClaimName    = "claim_name"
+	ClaimPrefix  = "claim_prefix"
+	ClientID     = "client_id"
+	ClientSecret = "client_secret"
+	Scopes       = "scopes"
 
-	EnvIdentityOpenIDClientID    = "MINIO_IDENTITY_OPENID_CLIENT_ID"
-	EnvIdentityOpenIDJWKSURL     = "MINIO_IDENTITY_OPENID_JWKS_URL"
-	EnvIdentityOpenIDURL         = "MINIO_IDENTITY_OPENID_CONFIG_URL"
-	EnvIdentityOpenIDClaimName   = "MINIO_IDENTITY_OPENID_CLAIM_NAME"
-	EnvIdentityOpenIDClaimPrefix = "MINIO_IDENTITY_OPENID_CLAIM_PREFIX"
-	EnvIdentityOpenIDScopes      = "MINIO_IDENTITY_OPENID_SCOPES"
+	EnvIdentityOpenIDClientID     = "MINIO_IDENTITY_OPENID_CLIENT_ID"
+	EnvIdentityOpenIDClientSecret = "MINIO_IDENTITY_OPENID_CLIENT_SECRET"
+	EnvIdentityOpenIDJWKSURL      = "MINIO_IDENTITY_OPENID_JWKS_URL"
+	EnvIdentityOpenIDURL          = "MINIO_IDENTITY_OPENID_CONFIG_URL"
+	EnvIdentityOpenIDClaimName    = "MINIO_IDENTITY_OPENID_CLAIM_NAME"
+	EnvIdentityOpenIDClaimPrefix  = "MINIO_IDENTITY_OPENID_CLAIM_PREFIX"
+	EnvIdentityOpenIDScopes       = "MINIO_IDENTITY_OPENID_SCOPES"
 )
 
 // DiscoveryDoc - parses the output from openid-configuration
@@ -289,6 +292,10 @@ var (
 			Key:   ClientID,
 			Value: "",
 		},
+		config.KV{
+			Key:   ClientSecret,
+			Value: "",
+		},
 		config.KV{
 			Key:   ClaimName,
 			Value: iampolicy.PolicyName,
@@ -325,13 +332,14 @@ func LookupConfig(kvs config.KVS, transport *http.Transport, closeRespFn func(io
 	}
 
 	c = Config{
-		ClaimName:   env.Get(EnvIdentityOpenIDClaimName, kvs.Get(ClaimName)),
-		ClaimPrefix: env.Get(EnvIdentityOpenIDClaimPrefix, kvs.Get(ClaimPrefix)),
-		publicKeys:  make(map[string]crypto.PublicKey),
-		ClientID:    env.Get(EnvIdentityOpenIDClientID, kvs.Get(ClientID)),
-		transport:   transport,
-		closeRespFn: closeRespFn,
-		mutex:       &sync.Mutex{}, // allocate for copying
+		ClaimName:    env.Get(EnvIdentityOpenIDClaimName, kvs.Get(ClaimName)),
+		ClaimPrefix:  env.Get(EnvIdentityOpenIDClaimPrefix, kvs.Get(ClaimPrefix)),
+		publicKeys:   make(map[string]crypto.PublicKey),
+		ClientID:     env.Get(EnvIdentityOpenIDClientID, kvs.Get(ClientID)),
+		ClientSecret: env.Get(EnvIdentityOpenIDClientSecret, kvs.Get(ClientSecret)),
+		transport:    transport,
+		closeRespFn:  closeRespFn,
+		mutex:        &sync.Mutex{}, // allocate for copying
 	}
 
 	configURL := env.Get(EnvIdentityOpenIDURL, kvs.Get(ConfigURL))

internal/config/logger.go

@@ -1,28 +0,0 @@
-// Copyright (c) 2015-2021 MinIO, Inc.
-//
-// This file is part of MinIO Object Storage stack
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-package config
-
-import "context"
-
-// Logger contains injected logger methods.
-var Logger = struct {
-	Info  func(msg string, data ...interface{})
-	LogIf func(ctx context.Context, err error, errKind ...interface{})
-}{
-	// Initialized via injection.
-}