Update hourly tier-stats only on succesful tiering (#14330)

This commit is contained in:
Krishnan Parthasarathi 2022-02-16 17:29:12 -08:00 committed by GitHub
parent b88c57ba93
commit cdab4a3b85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -221,9 +221,7 @@ func (t *transitionState) worker(ctx context.Context, objectAPI ObjectLayer) {
var err error var err error
if tier, err = transitionObject(ctx, objectAPI, oi); err != nil { if tier, err = transitionObject(ctx, objectAPI, oi); err != nil {
logger.LogIf(ctx, fmt.Errorf("Transition failed for %s/%s version:%s with %w", oi.Bucket, oi.Name, oi.VersionID, err)) logger.LogIf(ctx, fmt.Errorf("Transition failed for %s/%s version:%s with %w", oi.Bucket, oi.Name, oi.VersionID, err))
} } else {
atomic.AddInt32(&t.activeTasks, -1)
ts := tierStats{ ts := tierStats{
TotalSize: uint64(oi.Size), TotalSize: uint64(oi.Size),
NumVersions: 1, NumVersions: 1,
@ -233,6 +231,9 @@ func (t *transitionState) worker(ctx context.Context, objectAPI ObjectLayer) {
} }
t.addLastDayStats(tier, ts) t.addLastDayStats(tier, ts)
} }
atomic.AddInt32(&t.activeTasks, -1)
}
} }
} }