Implement SetConfig admin API handler. (#3792)

pkg/madmin/API.md

@@ -39,7 +39,7 @@ func main() {
 | Service operations|LockInfo operations|Healing operations|Config operations| Misc |
 |:---|:---|:---|:---|:---|
 |[`ServiceStatus`](#ServiceStatus)| [`ListLocks`](#ListLocks)| [`ListObjectsHeal`](#ListObjectsHeal)|[`GetConfig`](#GetConfig)| [`SetCredentials`](#SetCredentials)|
-|[`ServiceRestart`](#ServiceRestart)| [`ClearLocks`](#ClearLocks)| [`ListBucketsHeal`](#ListBucketsHeal)|||
+|[`ServiceRestart`](#ServiceRestart)| [`ClearLocks`](#ClearLocks)| [`ListBucketsHeal`](#ListBucketsHeal)|[`SetConfig`](#SetConfig)||
 | | |[`HealBucket`](#HealBucket) |||
 | | |[`HealObject`](#HealObject)|||
 | | |[`HealFormat`](#HealFormat)|||
@@ -306,7 +306,7 @@ __Example__
 
 <a name="SetCredentials"></a>
 
-### SetCredentials() error 
+### SetCredentials() error
 Set new credentials of a Minio setup.
 
 __Example__
@@ -320,4 +320,35 @@ __Example__
 
 ```
 
+<a name="SetConfig"></a>
+### SetConfig(config io.Reader) (SetConfigResult, error)
+Set config.json of a minio setup and restart setup for configuration
+change to take effect.
 
+
+| Param  | Type  | Description  |
+|---|---|---|
+|`st.Status`            | _bool_  | true if set-config succeeded, false otherwise. |
+|`st.NodeSummary.Name`  | _string_  | Network address of the node. |
+|`st.NodeSummary.Err`   | _string_ | String representation of the error (if any) on the node.|
+
+
+__Example__
+
+``` go
+    config := bytes.NewReader([]byte(`config.json contents go here`))
+    result, err := madmClnt.SetConfig(config)
+    if err != nil {
+        log.Fatalf("failed due to: %v", err)
+    }
+
+    var buf bytes.Buffer
+    enc := json.NewEncoder(&buf)
+    enc.SetEscapeHTML(false)
+    enc.SetIndent("", "\t")
+    err = enc.Encode(result)
+    if err != nil {
+        log.Fatalln(err)
+    }
+    log.Println("SetConfig: ", string(buf.Bytes()))
+```

pkg/madmin/config-commands.go

@@ -18,15 +18,36 @@
 package madmin
 
 import (
+	"bytes"
+	"encoding/json"
+	"io"
 	"io/ioutil"
 	"net/http"
 	"net/url"
 )
 
+const (
+	configQueryParam = "config"
+)
+
+// NodeSummary - represents the result of an operation part of
+// set-config on a node.
+type NodeSummary struct {
+	Name string `json:"name"`
+	Err  string `json:"err"`
+}
+
+// SetConfigResult - represents detailed results of a set-config
+// operation.
+type SetConfigResult struct {
+	NodeResults []NodeSummary `json:"nodeResults"`
+	Status      bool          `json:"status"`
+}
+
 // GetConfig - returns the config.json of a minio setup.
 func (adm *AdminClient) GetConfig() ([]byte, error) {
 	queryVal := make(url.Values)
-	queryVal.Set("config", "")
+	queryVal.Set(configQueryParam, "")
 
 	hdrs := make(http.Header)
 	hdrs.Set(minioAdminOpHeader, "get")
@@ -36,7 +57,7 @@ func (adm *AdminClient) GetConfig() ([]byte, error) {
 		customHeaders: hdrs,
 	}
 
-	// Execute GET on /?lock to list locks.
+	// Execute GET on /?config to get config of a setup.
 	resp, err := adm.executeMethod("GET", reqData)
 
 	defer closeResponse(resp)
@@ -44,6 +65,59 @@ func (adm *AdminClient) GetConfig() ([]byte, error) {
 		return nil, err
 	}
 
+	if resp.StatusCode != http.StatusOK {
+		return nil, httpRespToErrorResponse(resp)
+	}
+
 	// Return the JSON marshalled bytes to user.
 	return ioutil.ReadAll(resp.Body)
 }
+
+// SetConfig - set config supplied as config.json for the setup.
+func (adm *AdminClient) SetConfig(config io.Reader) (SetConfigResult, error) {
+	queryVal := url.Values{}
+	queryVal.Set(configQueryParam, "")
+
+	// Set x-minio-operation to set.
+	hdrs := make(http.Header)
+	hdrs.Set(minioAdminOpHeader, "set")
+
+	// Read config bytes to calculate MD5, SHA256 and content length.
+	configBytes, err := ioutil.ReadAll(config)
+	if err != nil {
+		return SetConfigResult{}, err
+	}
+
+	reqData := requestData{
+		queryValues:        queryVal,
+		customHeaders:      hdrs,
+		contentBody:        bytes.NewReader(configBytes),
+		contentMD5Bytes:    sumMD5(configBytes),
+		contentSHA256Bytes: sum256(configBytes),
+	}
+
+	// Execute PUT on /?config to set config.
+	resp, err := adm.executeMethod("PUT", reqData)
+
+	defer closeResponse(resp)
+	if err != nil {
+		return SetConfigResult{}, err
+	}
+
+	if resp.StatusCode != http.StatusOK {
+		return SetConfigResult{}, httpRespToErrorResponse(resp)
+	}
+
+	var result SetConfigResult
+	jsonBytes, err := ioutil.ReadAll(resp.Body)
+	if err != nil {
+		return SetConfigResult{}, err
+	}
+
+	err = json.Unmarshal(jsonBytes, &result)
+	if err != nil {
+		return SetConfigResult{}, err
+	}
+
+	return result, nil
+}

pkg/madmin/examples/set-config.go

@@ -0,0 +1,156 @@
+// +build ignore
+
+/*
+ * Minio Cloud Storage, (C) 2017 Minio, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package main
+
+import (
+	"bytes"
+	"encoding/json"
+	"fmt"
+	"log"
+
+	"github.com/minio/minio/pkg/madmin"
+)
+
+var configJSON = []byte(`{
+	"version": "13",
+	"credential": {
+		"accessKey": "minio",
+		"secretKey": "minio123"
+	},
+	"region": "us-west-1",
+	"logger": {
+		"console": {
+			"enable": true,
+			"level": "fatal"
+		},
+		"file": {
+			"enable": false,
+			"fileName": "",
+			"level": ""
+		}
+	},
+	"notify": {
+		"amqp": {
+			"1": {
+				"enable": false,
+				"url": "",
+				"exchange": "",
+				"routingKey": "",
+				"exchangeType": "",
+				"mandatory": false,
+				"immediate": false,
+				"durable": false,
+				"internal": false,
+				"noWait": false,
+				"autoDeleted": false
+			}
+		},
+		"nats": {
+			"1": {
+				"enable": false,
+				"address": "",
+				"subject": "",
+				"username": "",
+				"password": "",
+				"token": "",
+				"secure": false,
+				"pingInterval": 0,
+				"streaming": {
+					"enable": false,
+					"clusterID": "",
+					"clientID": "",
+					"async": false,
+					"maxPubAcksInflight": 0
+				}
+			}
+		},
+		"elasticsearch": {
+			"1": {
+				"enable": false,
+				"url": "",
+				"index": ""
+			}
+		},
+		"redis": {
+			"1": {
+				"enable": false,
+				"address": "",
+				"password": "",
+				"key": ""
+			}
+		},
+		"postgresql": {
+			"1": {
+				"enable": false,
+				"connectionString": "",
+				"table": "",
+				"host": "",
+				"port": "",
+				"user": "",
+				"password": "",
+				"database": ""
+			}
+		},
+		"kafka": {
+			"1": {
+				"enable": false,
+				"brokers": null,
+				"topic": ""
+			}
+		},
+		"webhook": {
+			"1": {
+				"enable": false,
+				"endpoint": ""
+			}
+		}
+	}
+}`)
+
+func main() {
+	// Note: YOUR-ACCESSKEYID, YOUR-SECRETACCESSKEY are
+	// dummy values, please replace them with original values.
+
+	// Note: YOUR-ACCESSKEYID, YOUR-SECRETACCESSKEY are
+	// dummy values, please replace them with original values.
+
+	// API requests are secure (HTTPS) if secure=true and insecure (HTTPS) otherwise.
+	// New returns an Minio Admin client object.
+	madmClnt, err := madmin.New("your-minio.example.com:9000", "YOUR-ACCESSKEYID", "YOUR-SECRETACCESSKEY", true)
+	if err != nil {
+		log.Fatalln(err)
+	}
+
+	result, err := madmClnt.SetConfig(bytes.NewReader(configJSON))
+	if err != nil {
+		log.Fatalln(err)
+	}
+
+	var buf bytes.Buffer
+	enc := json.NewEncoder(&buf)
+	enc.SetEscapeHTML(false)
+	enc.SetIndent("", "\t")
+	err = enc.Encode(result)
+	if err != nil {
+		log.Fatalln(err)
+	}
+
+	fmt.Println("SetConfig: ", string(buf.Bytes()))
+}