MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-25 22:55:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1218 from hackintoshrao/better-fs-util-test

Browse Source 
Test: Better structuring of fs-utils test
This commit is contained in:
Harshavardhana 2016-03-11 06:54:43 -08:00
commit c81f4b0228
1 changed files with 76 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

110
pkg/fs/fs-utils_test.go
View File

@ -20,53 +20,95 @@ import (
"testing" "testing"
) )
func ensureBucketName(name string, t *testing.T, pass bool) { //Validating bucket name.
if pass && IsValidBucketName(name) { func ensureBucketName(t *testing.T, name string, testNum int, pass bool) {
return isValidBucketName := IsValidBucketName(name)
if pass && !isValidBucketName {
t.Errorf("Test case %d: Expected \"%s\" to be a valid bucket name", testNum, name)
} }
if !pass && !IsValidBucketName(name) { if !pass && isValidBucketName {
return t.Errorf("Test case %d: Expected bucket name \"%s\" to be invalid", testNum, name)
} }
t.Errorf("\"%s\" should have passed [%t]\n", name, pass)
} }
func TestIsValidBucketName(t *testing.T) { func TestIsValidBucketName(t *testing.T) {
ensureBucketName("lol", t, true) testCases := []struct {
ensureBucketName("s3-eu-west-1.amazonaws.com", t, true) bucketName string
ensureBucketName("ideas-are-more-powerful-than-guns", t, true) shouldPass bool
ensureBucketName("testbucket", t, true) }{
ensureBucketName("1bucket", t, true) //cases which should pass the test
ensureBucketName("bucket1", t, true) //passing in valid bucket names
{"lol", true},
{"1-this-is-valid", true},
{"1-this-too-is-valid-1", true},
{"this.works.too.1", true},
{"1234567", true},
{"123", true},
{"s3-eu-west-1.amazonaws.com", true},
{"ideas-are-more-powerful-than-guns", true},
{"testbucket", true},
{"1bucket", true},
{"bucket1", true},
//cases for which test should fail
//passing invalid bucket names
{"------", false},
{"$this-is-not-valid-too", false},
{"contains-$-dollar", false},
{"contains-^-carrot", false},
{"contains-$-dollar", false},
{"contains-$-dollar", false},
{"......", false},
{"", false},
{"a", false},
{"ab", false},
{".starts-with-a-dot", false},
{"ends-with-a-dot.", false},
{"ends-with-a-dash-", false},
{"-starts-with-a-dash", false},
{"THIS-BEINGS-WITH-UPPERCASe", false},
{"tHIS-ENDS-WITH-UPPERCASE", false},
{"ThisBeginsAndEndsWithUpperCase", false},
{"una ñina", false},
{"lalalallalallalalalallalallalala-theString-size-is-greater-than-64", false},
}
ensureBucketName("testing.", t, false) for i, testCase := range testCases {
ensureBucketName("", t, false) ensureBucketName(t, testCase.bucketName, i+1, testCase.shouldPass)
ensureBucketName("......", t, false) }
ensureBucketName("THIS-IS-UPPERCASE", t, false)
ensureBucketName("una ñina", t, false)
ensureBucketName("lalalallalallalalalallalallalallalallalallalallalallalallallalala", t, false)
} }
func ensureObjectName(name string, t *testing.T, pass bool) { //Test for validating object name.
if pass && IsValidObjectName(name) { func ensureObjectName(t *testing.T, name string, testNum int, pass bool) {
return isValidObjectName := IsValidObjectName(name)
if pass && !isValidObjectName {
t.Errorf("Test case %d: Expected \"%s\" to be a valid object name", testNum, name)
} }
if !pass && !IsValidObjectName(name) { if !pass && isValidObjectName {
return t.Errorf("Test case %d: Expected object name \"%s\" to be invalid", testNum, name)
} }
t.Errorf("\"%s\" should have passed [%t]\n", name, pass)
} }
func TestIsValidObjectName(t *testing.T) { func TestIsValidObjectName(t *testing.T) {
ensureObjectName("object", t, true) testCases := []struct {
ensureObjectName("The Shining Script <v1>.pdf", t, true) objectName string
ensureObjectName("Cost Benefit Analysis (2009-2010).pptx", t, true) shouldPass bool
ensureObjectName("117Gn8rfHL2ACARPAhaFd0AGzic9pUbIA/5OCn5A", t, true) }{
ensureObjectName("SHØRT", t, true) //cases which should pass the test
ensureObjectName("There are far too many object names, and far too few bucket names!", t, true) //passing in valid object name
{"object", true},
{"The Shining Script <v1>.pdf", true},
{"Cost Benefit Analysis (2009-2010).pptx", true},
{"117Gn8rfHL2ACARPAhaFd0AGzic9pUbIA/5OCn5A", true},
{"SHØRT", true},
{"There are far too many object names, and far too few bucket names!", true},
//cases for which test should fail
//passing invalid object names
{"", false},
{string([]byte{0xff, 0xfe, 0xfd}), false},
}
ensureObjectName("", t, false) for i, testCase := range testCases {
// Bad UTF8 strings should not pass. ensureObjectName(t, testCase.objectName, i+1, testCase.shouldPass)
ensureObjectName(string([]byte{0xff, 0xfe, 0xfd}), t, false) }
} }