re-implement pickValidInfo dataDir, move to quorum calculation (#13681)

dataDir loosely based on maxima is incorrect and does not
work in all situations such as disks in the following order

- xl.json migration to xl.meta there may be partial xl.json's
  leftover if some disks are not yet connected when the disk
  is yet to come up, since xl.json mtime and xl.meta is
  same the dataDir maxima doesn't work properly leading to
  quorum issues.

- its also possible that XLV1 might be true among the disks
  available, make sure to keep FileInfo based on common quorum
  and skip unexpected disks with the older data format.

Also, this PR tests upgrade from older to a newer release if the 
data is readable and matches the checksum.

NOTE: this is just initial work we can build on top of this to do further tests.

cmd/xl-storage.go

@@ -105,8 +105,6 @@ type xlStorage struct {
 	formatLastCheck time.Time
 
 	diskInfoCache timedValue
-
-	ctx context.Context
 	sync.RWMutex
 
 	// mutex to prevent concurrent read operations overloading walks.
@@ -255,7 +253,6 @@ func newXLStorage(ep Endpoint) (*xlStorage, error) {
 		diskPath:   path,
 		endpoint:   ep,
 		globalSync: env.Get(config.EnvFSOSync, config.EnableOff) == config.EnableOn,
-		ctx:        GlobalContext,
 		rootDisk:   rootDisk,
 		poolIndex:  -1,
 		setIndex:   -1,
@@ -1952,6 +1949,9 @@ func (s *xlStorage) Delete(ctx context.Context, volume string, path string, recu
 // RenameData - rename source path to destination path atomically, metadata and data directory.
 func (s *xlStorage) RenameData(ctx context.Context, srcVolume, srcPath string, fi FileInfo, dstVolume, dstPath string) (err error) {
 	defer func() {
+		if err != nil {
+			logger.LogIf(ctx, err)
+		}
 		if err == nil {
 			if s.globalSync {
 				globalSync()
@@ -2045,7 +2045,7 @@ func (s *xlStorage) RenameData(ctx context.Context, srcVolume, srcPath string, f
 	if len(dstBuf) > 0 {
 		if isXL2V1Format(dstBuf) {
 			if err = xlMeta.Load(dstBuf); err != nil {
-				logger.LogIf(s.ctx, err)
+				logger.LogIf(ctx, err)
 				// Data appears corrupt. Drop data.
 				xlMeta = xlMetaV2{}
 			}
@@ -2054,11 +2054,11 @@ func (s *xlStorage) RenameData(ctx context.Context, srcVolume, srcPath string, f
 			xlMetaLegacy := &xlMetaV1Object{}
 			var json = jsoniter.ConfigCompatibleWithStandardLibrary
 			if err := json.Unmarshal(dstBuf, xlMetaLegacy); err != nil {
-				logger.LogIf(s.ctx, err)
+				logger.LogIf(ctx, err)
 				// Data appears corrupt. Drop data.
 			} else {
 				if err = xlMeta.AddLegacy(xlMetaLegacy); err != nil {
-					logger.LogIf(s.ctx, err)
+					logger.LogIf(ctx, err)
 				}
 				legacyPreserved = true
 			}
@@ -2195,7 +2195,6 @@ func (s *xlStorage) RenameData(ctx context.Context, srcVolume, srcPath string, f
 					s.deleteFile(dstVolumeDir, legacyDataPath, true)
 				}
 				s.deleteFile(dstVolumeDir, dstDataPath, false)
-
 				if err != errFileNotFound {
 					logger.LogIf(ctx, err)
 				}
@@ -2373,8 +2372,8 @@ func (s *xlStorage) VerifyFile(ctx context.Context, volume, path string, fi File
 				errVolumeNotFound,
 				errFileCorrupt,
 			}...) {
-				logger.GetReqInfo(s.ctx).AppendTags("disk", s.String())
-				logger.LogIf(s.ctx, err)
+				logger.GetReqInfo(ctx).AppendTags("disk", s.String())
+				logger.LogIf(ctx, err)
 			}
 			return err
 		}