MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-11 06:20:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

madmin: All APIs return ErrorResponse error type (#3632)

Browse Source 
Avoid returning errors.New("Got HTTP Status") in all APIs
This commit is contained in:
Anis Elleuch
2017-01-26 01:01:29 +01:00
committed by Harshavardhana
parent 82373e3d50
commit c753b5dfeb
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/madmin/heal-commands.go
View File

@@ -19,7 +19,6 @@ package madmin
import (
"encoding/xml"
"errors"
"fmt"
"net/http"
"net/url"
@@ -207,7 +206,8 @@ func (adm *AdminClient) listObjectsHeal(bucket, prefix, marker, delimiter string
}
if resp.StatusCode != http.StatusOK {
return toBeHealedObjects, errors.New("Got HTTP Status: " + resp.Status)
return toBeHealedObjects, httpRespToErrorResponse(resp)
}
err = xml.NewDecoder(resp.Body).Decode(&toBeHealedObjects)
@@ -309,7 +309,7 @@ func (adm *AdminClient) ListBucketsHeal() ([]BucketInfo, error) {
}
if resp.StatusCode != http.StatusOK {
return []BucketInfo{}, errors.New("Got HTTP Status: " + resp.Status)
return []BucketInfo{}, httpRespToErrorResponse(resp)
}
var listBucketsHealResult ListBucketsHealResponse
@@ -364,7 +364,7 @@ func (adm *AdminClient) HealBucket(bucket string, dryrun bool) error {
}
if resp.StatusCode != http.StatusOK {
return errors.New("Got HTTP Status: " + resp.Status)
return httpRespToErrorResponse(resp)
}
return nil
@@ -398,7 +398,7 @@ func (adm *AdminClient) HealObject(bucket, object string, dryrun bool) error {
}
if resp.StatusCode != http.StatusOK {
return errors.New("Got HTTP Status: " + resp.Status)
return httpRespToErrorResponse(resp)
}
return nil
@@ -430,7 +430,7 @@ func (adm *AdminClient) HealFormat(dryrun bool) error {
}
if resp.StatusCode != http.StatusOK {
return errors.New("Got HTTP Status: " + resp.Status)
return httpRespToErrorResponse(resp)
}
return nil