Fix failing unit tests in browser (#5688)

* format js files using prettier

Used the following command to format the files
prettier --write "browser/app/js/**/*.js"

* fix failing unit tests in browser

browser/app/js/alert/AlertContainer.js

@@ -28,13 +28,13 @@ export const AlertContainer = ({ alert, clearAlert }) => {
 
 const mapStateToProps = state => {
   return {
-    alert: state.alert,
+    alert: state.alert
   }
 }
 
 const mapDispatchToProps = dispatch => {
   return {
-    clearAlert: () => dispatch(alertActions.clear()),
+    clearAlert: () => dispatch(alertActions.clear())
   }
 }
 

browser/app/js/alert/__tests___/Alert.test.js

@@ -26,10 +26,10 @@ describe("Alert", () => {
   it("should call onDismiss when close button is clicked", () => {
     const onDismiss = jest.fn()
     const wrapper = mount(
-      <Alert show={true} type="danger" message="test" onDismiss={onDismiss} />,
+      <Alert show={true} type="danger" message="test" onDismiss={onDismiss} />
     )
-    wrapper.find("button").simulate("click", {
-      preventDefault: jest.fn(),
+    wrapper.find("i").simulate("click", {
+      preventDefault: jest.fn()
     })
     expect(onDismiss).toHaveBeenCalled()
   })

browser/app/js/alert/__tests___/AlertContainer.test.js

@@ -21,15 +21,13 @@ import { AlertContainer } from "../AlertContainer"
 describe("Alert", () => {
   it("should render without crashing", () => {
     shallow(
-      <AlertContainer
-        alert={{ show: true, type: "danger", message: "Test" }}
-      />,
+      <AlertContainer alert={{ show: true, type: "danger", message: "Test" }} />
     )
   })
 
   it("should render nothing if message is empty", () => {
     const wrapper = shallow(
-      <AlertContainer alert={{ show: true, type: "danger", message: "" }} />,
+      <AlertContainer alert={{ show: true, type: "danger", message: "" }} />
     )
     expect(wrapper.find("Alert").length).toBe(0)
   })

browser/app/js/alert/__tests___/actions.test.js

@@ -32,15 +32,15 @@ describe("Alert actions", () => {
         alert: {
           id: 0,
           message: "Test alert",
-          type: "danger",
-        },
-      },
+          type: "danger"
+        }
+      }
     ]
     store.dispatch(
       actionsAlert.set({
         message: "Test alert",
-        type: "danger",
-      }),
+        type: "danger"
+      })
     )
     const actions = store.getActions()
     expect(actions).toEqual(expectedActions)
@@ -53,20 +53,20 @@ describe("Alert actions", () => {
         type: "alert/SET",
         alert: {
           id: 1,
-          message: "Test alert",
-        },
+          message: "Test alert"
+        }
       },
       {
         type: "alert/CLEAR",
         alert: {
-          id: 1,
-        },
-      },
+          id: 1
+        }
+      }
     ]
     store.dispatch(
       actionsAlert.set({
-        message: "Test alert",
-      }),
+        message: "Test alert"
+      })
     )
     jest.runAllTimers()
     const actions = store.getActions()
@@ -77,8 +77,8 @@ describe("Alert actions", () => {
     const store = mockStore()
     const expectedActions = [
       {
-        type: "alert/CLEAR",
-      },
+        type: "alert/CLEAR"
+      }
     ]
     store.dispatch(actionsAlert.clear())
     const actions = store.getActions()

browser/app/js/alert/__tests___/reducer.test.js

@@ -21,7 +21,7 @@ describe("alert reducer", () => {
   it("should return the initial state", () => {
     expect(reducer(undefined, {})).toEqual({
       show: false,
-      type: "danger",
+      type: "danger"
     })
   })
 
@@ -32,14 +32,14 @@ describe("alert reducer", () => {
         alert: {
           id: 1,
           type: "danger",
-          message: "Test message",
-        },
-      }),
+          message: "Test message"
+        }
+      })
     ).toEqual({
       show: true,
       id: 1,
       type: "danger",
-      message: "Test message",
+      message: "Test message"
     })
   })
 
@@ -49,15 +49,15 @@ describe("alert reducer", () => {
         {
           show: true,
           type: "danger",
-          message: "Test message",
+          message: "Test message"
         },
         {
-          type: actionsAlert.CLEAR,
-        },
-      ),
+          type: actionsAlert.CLEAR
+        }
+      )
     ).toEqual({
       show: false,
-      type: "danger",
+      type: "danger"
     })
   })
 
@@ -68,18 +68,18 @@ describe("alert reducer", () => {
           show: true,
           id: 1,
           type: "danger",
-          message: "Test message",
+          message: "Test message"
         },
         {
           type: actionsAlert.CLEAR,
           alert: {
-            id: 1,
-          },
-        },
-      ),
+            id: 1
+          }
+        }
+      )
     ).toEqual({
       show: false,
-      type: "danger",
+      type: "danger"
     })
   })
 
@@ -90,20 +90,20 @@ describe("alert reducer", () => {
           show: true,
           id: 1,
           type: "danger",
-          message: "Test message",
+          message: "Test message"
         },
         {
           type: actionsAlert.CLEAR,
           alert: {
-            id: 2,
-          },
-        },
-      ),
+            id: 2
+          }
+        }
+      )
     ).toEqual({
       show: true,
       id: 1,
       type: "danger",
-      message: "Test message",
+      message: "Test message"
     })
   })
 })

browser/app/js/alert/actions.js

@@ -27,22 +27,22 @@ export const set = alert => {
         dispatch({
           type: CLEAR,
           alert: {
-            id,
-          },
+            id
+          }
         })
       }, 5000)
     }
     dispatch({
       type: SET,
       alert: Object.assign({}, alert, {
-        id,
-      }),
+        id
+      })
     })
   }
 }
 
 export const clear = () => {
   return {
-    type: CLEAR,
+    type: CLEAR
   }
 }

browser/app/js/alert/reducer.js

@@ -18,7 +18,7 @@ import * as actionsAlert from "./actions"
 
 const initialState = {
   show: false,
-  type: "danger",
+  type: "danger"
 }
 export default (state = initialState, action) => {
   switch (action.type) {
@@ -27,7 +27,7 @@ export default (state = initialState, action) => {
         show: true,
         id: action.alert.id,
         type: action.alert.type,
-        message: action.alert.message,
+        message: action.alert.message
       }
     case actionsAlert.CLEAR:
       if (action.alert && action.alert.id != state.id) {