feat: drive sub-sys to max timeout reload (#18501)

internal/config/config.go

@@ -117,7 +117,7 @@ const (
 	CrawlerSubSys        = madmin.CrawlerSubSys
 	SubnetSubSys         = madmin.SubnetSubSys
 	CallhomeSubSys       = madmin.CallhomeSubSys
-
+	DriveSubSys          = madmin.DriveSubSys
 	// Add new constants here (similar to above) if you add new fields to config.
 )
 
@@ -179,6 +179,7 @@ var SubSystemsDynamic = set.CreateStringSet(
 	HealSubSys,
 	SubnetSubSys,
 	CallhomeSubSys,
+	DriveSubSys,
 	LoggerWebhookSubSys,
 	AuditWebhookSubSys,
 	AuditKafkaSubSys,
@@ -204,6 +205,7 @@ var SubSystemsSingleTargets = set.CreateStringSet(
 	ScannerSubSys,
 	SubnetSubSys,
 	CallhomeSubSys,
+	DriveSubSys,
 	CacheSubSys,
 )
 

internal/config/drive/drive.go

@@ -0,0 +1,97 @@
+// Copyright (c) 2015-2023 MinIO, Inc.
+//
+// This file is part of MinIO Object Storage stack
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package drive
+
+import (
+	"sync"
+	"time"
+
+	"github.com/minio/minio/internal/config"
+	"github.com/minio/pkg/v2/env"
+)
+
+// DefaultKVS - default KVS for drive
+var DefaultKVS = config.KVS{
+	config.KV{
+		Key:   MaxTimeout,
+		Value: "",
+	},
+}
+
+// Config represents the subnet related configuration
+type Config struct {
+	// MaxTimeout - maximum timeout for a drive operation
+	MaxTimeout time.Duration `json:"maxTimeout"`
+	mutex      sync.RWMutex
+}
+
+// Update - updates the config with latest values
+func (c *Config) Update(new *Config) error {
+	c.mutex.Lock()
+	defer c.mutex.Unlock()
+	c.MaxTimeout = getMaxTimeout(new.MaxTimeout)
+	return nil
+}
+
+// GetMaxTimeout - returns the max timeout value.
+func (c *Config) GetMaxTimeout() time.Duration {
+	c.mutex.RLock()
+	defer c.mutex.RUnlock()
+	return getMaxTimeout(c.MaxTimeout)
+}
+
+// LookupConfig - lookup config and override with valid environment settings if any.
+func LookupConfig(kvs config.KVS) (cfg *Config, err error) {
+	if err = config.CheckValidKeys(config.DriveSubSys, kvs, DefaultKVS); err != nil {
+		return cfg, err
+	}
+	// if not set. Get default value from environment
+	d := kvs.GetWithDefault(MaxTimeout, DefaultKVS)
+	if d == "" {
+		d = env.Get("_MINIO_DRIVE_MAX_TIMEOUT", "")
+		if d == "" {
+			d = env.Get("_MINIO_DISK_MAX_TIMEOUT", "")
+		}
+	}
+	cfg = &Config{
+		mutex: sync.RWMutex{},
+	}
+	dur, _ := time.ParseDuration(d)
+	if dur < time.Second {
+		cfg.MaxTimeout = time.Minute * 2
+	} else {
+		cfg.MaxTimeout = getMaxTimeout(dur)
+	}
+	return cfg, err
+}
+
+func getMaxTimeout(t time.Duration) time.Duration {
+	if t < time.Second {
+		// get default value
+		d := env.Get("_MINIO_DRIVE_MAX_TIMEOUT", "")
+		if d == "" {
+			d = env.Get("_MINIO_DISK_MAX_TIMEOUT", "")
+		}
+		dur, _ := time.ParseDuration(d)
+		if dur < time.Second {
+			return time.Minute * 2
+		}
+		return dur
+	}
+	return t
+}

internal/config/drive/help.go

@@ -0,0 +1,34 @@
+// Copyright (c) 2015-2023 MinIO, Inc.
+//
+// This file is part of MinIO Object Storage stack
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package drive
+
+import "github.com/minio/minio/internal/config"
+
+var (
+	// MaxTimeout is the max timeout for drive
+	MaxTimeout = "max_timeout"
+	// HelpDrive is help for drive
+	HelpDrive = config.HelpKVS{
+		config.HelpKV{
+			Key:         MaxTimeout,
+			Type:        "string",
+			Description: "set per call max_timeout for the drive, defaults to 2 minutes",
+			Optional:    true,
+		},
+	}
+)