MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 12:52:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add User-Agent header with MinIO release details in http logs (#7843)

Browse Source 
This would allow http log target server to distinguish between log
messages across different versions of MinIO deployments.
This commit is contained in:
Krishnan Parthasarathi
2019-08-14 11:43:43 -07:00
committed by Harshavardhana
parent 1cd801b2e9
commit bbb56739bd
7 changed files with 53 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/logger/target/http/http.go
View File

@@ -37,7 +37,9 @@ type Target struct {
// HTTP(s) endpoint
endpoint string
client gohttp.Client
// User-Agent to be set on each log request sent to the `endpoint`
userAgent string
client gohttp.Client
}
func (h *Target) startHTTPLogger() {
@@ -56,6 +58,10 @@ func (h *Target) startHTTPLogger() {
}
req.Header.Set(xhttp.ContentType, "application/json")
// Set user-agent to indicate MinIO release
// version to the configured log endpoint
req.Header.Set("User-Agent", h.userAgent)
resp, err := h.client.Do(req)
if err != nil {
continue
@@ -69,9 +75,10 @@ func (h *Target) startHTTPLogger() {
// New initializes a new logger target which
// sends log over http to the specified endpoint
func New(endpoint string, transport *gohttp.Transport) *Target {
func New(endpoint, userAgent string, transport *gohttp.Transport) *Target {
h := Target{
endpoint: endpoint,
endpoint: endpoint,
userAgent: userAgent,
client: gohttp.Client{
Transport: transport,
},