MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-06 12:50:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix divide by 0 error when directio.AlignSize is 0 (#7591)

Browse Source
This commit is contained in:
Krishna Srinivas 2019-04-26 16:08:15 -07:00 committed by kannappanr
parent 83ca1a8d64
commit b93ef73f9b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/posix.go
View File

@ -45,6 +45,7 @@ const (
diskMinTotalSpace = diskMinFreeSpace // Min 900MiB total space. diskMinTotalSpace = diskMinFreeSpace // Min 900MiB total space.
maxAllowedIOError = 5 maxAllowedIOError = 5
posixWriteBlockSize = 4 * humanize.MiByte posixWriteBlockSize = 4 * humanize.MiByte
directioAlignSize = 4096 // DirectIO alignment needs to be 4K. Defined here as directio.AlignSize is defined as 0 in MacOS causing divide by 0 error.
) )
// isValidVolname verifies a volname name in accordance with object // isValidVolname verifies a volname name in accordance with object
@ -1142,7 +1143,7 @@ func (s *posix) CreateFile(volume, path string, fileSize int64, r io.Reader) (er
if err != nil { if err != nil {
return err return err
} }
remainingAligned := (remaining / directio.AlignSize) * directio.AlignSize remainingAligned := (remaining / directioAlignSize) * directioAlignSize
remainingAlignedBuf := buf[:remainingAligned] remainingAlignedBuf := buf[:remainingAligned]
remainingUnalignedBuf := buf[remainingAligned:] remainingUnalignedBuf := buf[remainingAligned:]
if len(remainingAlignedBuf) > 0 { if len(remainingAlignedBuf) > 0 {