change directory objects to never create new versions (#17109)

.github/markdown-lint-cfg.yaml

@@ -1,5 +0,0 @@
-# Config file for markdownlint-cli
-MD033:
-  allowed_elements:
-    - details
-    - summary

.github/workflows/markdown-lint.yaml

@@ -1,30 +0,0 @@
-name: Markdown Linter
-
-on:
-  pull_request:
-    branches:
-    - master
-
-# This ensures that previous jobs for the PR are canceled when the PR is
-# updated.
-concurrency: 
-  group: ${{ github.workflow }}-${{ github.head_ref }}
-  cancel-in-progress: true
-
-permissions:
-  contents: read
-
-jobs:
-  lint:
-    name: Lint all docs
-    runs-on: ubuntu-latest
-    steps:
-    - name: Check out code
-      uses: actions/checkout@v3
-
-    - name: Lint all docs
-      run: |
-        npm install -g markdownlint-cli
-        markdownlint --fix '**/*.md' \
-          --config /home/runner/work/minio/minio/.github/markdown-lint-cfg.yaml \
-          --disable MD013 MD040 MD051

cmd/bucket-handlers_test.go

@@ -657,13 +657,14 @@ func testAPIDeleteMultipleObjectsHandler(obj ObjectLayer, instanceType, bucketNa
 ) {
 	var err error
 
-	contentBytes := []byte("hello")
 	sha256sum := ""
 	var objectNames []string
 	for i := 0; i < 10; i++ {
+		contentBytes := []byte("hello")
 		objectName := "test-object-" + strconv.Itoa(i)
 		if i == 0 {
 			objectName += "/"
+			contentBytes = []byte{}
 		}
 		// uploading the object.
 		_, err = obj.PutObject(GlobalContext, bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(contentBytes), int64(len(contentBytes)), "", sha256sum), ObjectOptions{})
@@ -676,6 +677,7 @@ func testAPIDeleteMultipleObjectsHandler(obj ObjectLayer, instanceType, bucketNa
 		objectNames = append(objectNames, objectName)
 	}
 
+	contentBytes := []byte("hello")
 	for _, name := range []string{"private/object", "public/object"} {
 		// Uploading the object with retention enabled
 		_, err = obj.PutObject(GlobalContext, bucketName, name, mustGetPutObjReader(t, bytes.NewReader(contentBytes), int64(len(contentBytes)), "", sha256sum), ObjectOptions{})

cmd/data-usage.go

@@ -81,7 +81,7 @@ func loadPrefixUsageFromBackend(ctx context.Context, objAPI ObjectLayer, bucket
 
 				for id, usageInfo := range cache.flattenChildrens(*root) {
 					prefix := decodeDirObject(strings.TrimPrefix(id, bucket+slashSeparator))
-					// decodeDirObject to avoid any __XL_DIR__ objects
+					// decodeDirObject to avoid any __XLDIR__ objects
 					m[prefix] += uint64(usageInfo.Size)
 				}
 			}

cmd/erasure-server-pool.go

@@ -937,7 +937,15 @@ func (z *erasureServerPools) PutObject(ctx context.Context, bucket string, objec
 		return ObjectInfo{}, err
 	}
 
+	origObject := object
 	object = encodeDirObject(object)
+	// Only directory objects skip creating new versions.
+	if object != origObject && isDirObject(object) && data.Size() == 0 {
+		// Treat all directory PUTs to behave as if they are performed
+		// on an unversioned bucket.
+		opts.Versioned = false
+		opts.VersionSuspended = false
+	}
 
 	if z.SinglePool() {
 		if !isMinioMetaBucketName(bucket) {

cmd/metacache-entries.go

@@ -55,7 +55,7 @@ func (e metaCacheEntry) isObject() bool {
 	return len(e.metadata) > 0
 }
 
-// isObjectDir returns if the entry is representing an object__XL_DIR__
+// isObjectDir returns if the entry is representing an object/
 func (e metaCacheEntry) isObjectDir() bool {
 	return len(e.metadata) > 0 && strings.HasSuffix(e.name, slashSeparator)
 }

cmd/utils.go

@@ -1031,6 +1031,10 @@ func decodeDirObject(object string) string {
 	return object
 }
 
+func isDirObject(object string) bool {
+	return HasSuffix(object, globalDirSuffix)
+}
+
 // Helper method to return total number of nodes in cluster
 func totalNodeCount() uint64 {
 	peers, _ := globalEndpoints.peers()

docs/bucket/replication/setup_2site_existing_replication.sh

@@ -132,4 +132,61 @@ if [ $ret -ne 0 ]; then
     exit 1
 fi
 
+./mc mb sitea/bucket-version/
+./mc mb siteb/bucket-version
+
+./mc version enable sitea/bucket-version/
+./mc version enable siteb/bucket-version/
+
+echo "adding replication rule for site a -> site b"
+./mc replicate add sitea/bucket-version/ \
+     --remote-bucket http://minio:minio123@127.0.0.1:9004/bucket-version
+
+./mc mb sitea/bucket-version/directory/
+
+sleep 2s
+
+./mc ls -r --versions sitea/bucket-version/ > /tmp/sitea_dirs.txt
+./mc ls -r --versions siteb/bucket-version/ > /tmp/siteb_dirs.txt
+
+out=$(diff -qpruN /tmp/sitea_dirs.txt /tmp/siteb_dirs.txt)
+ret=$?
+if [ $ret -ne 0 ]; then
+    echo "BUG: expected no 'diff' after replication: $out"
+    exit 1
+fi
+
+./mc rm -r --versions --force sitea/bucket-version/
+
+sleep 2s
+
+./mc ls -r --versions sitea/bucket-version/ > /tmp/sitea_dirs.txt
+./mc ls -r --versions siteb/bucket-version/ > /tmp/siteb_dirs.txt
+
+out=$(diff -qpruN /tmp/sitea_dirs.txt /tmp/siteb_dirs.txt)
+ret=$?
+if [ $ret -ne 0 ]; then
+    echo "BUG: expected no 'diff' after replication: $out"
+    exit 1
+fi
+
+## check if we don't create delete markers on the directory objects, its always permanent delete.
+./mc mb sitea/bucket-version/directory/
+
+sleep 2s
+
+./mc rm -r --force sitea/bucket-version/
+
+sleep 2s
+
+./mc ls -r --versions sitea/bucket-version/ > /tmp/sitea_dirs.txt
+./mc ls -r --versions siteb/bucket-version/ > /tmp/siteb_dirs.txt
+
+out=$(diff -qpruN /tmp/sitea_dirs.txt /tmp/siteb_dirs.txt)
+ret=$?
+if [ $ret -ne 0 ]; then
+    echo "BUG: expected no 'diff' after replication: $out"
+    exit 1
+fi
+
 catch

docs/bucket/versioning/README.md

@@ -78,8 +78,6 @@ To exclude objects under a list of prefix (glob) patterns from being versioned,
 ```
 <VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
         <Status>Enabled</Status>
-        <ExcludeFolders>true</ExcludeFolders>
-
         <ExcludedPrefixes>
           <Prefix>*/_temporary</Prefix>
         </ExcludedPrefixes>