utils: Fix unit tests issue. (#2441)

utils_test.go

@@ -18,21 +18,79 @@ package main
 
 import "testing"
 
-// ShutdownCallback simulates a successful and failure exit here.
+// Tests maximum object size.
-func TestShutdownCallbackSuccess(t *testing.T) {
+func TestMaxObjectSize(t *testing.T) {
-	// initialize graceful shutdown
+	sizes := []struct {
-	dummySuccess := func(code int) {
+		isMax bool
-		if code != int(exitSuccess) {
+		size  int64
-			t.Fatalf("Expected %d, got %d instead.", code, exitSuccess)
+	}{
+		// Test - 1 - maximum object size.
+		{
+			true,
+			maxObjectSize + 1,
+		},
+		// Test - 2 - not maximum object size.
+		{
+			false,
+			maxObjectSize - 1,
+		},
+	}
+	for i, s := range sizes {
+		isMax := isMaxObjectSize(s.size)
+		if isMax != s.isMax {
+			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMax, isMax)
+		}
+	}
+}
+
+// Tests minimum allowed part size.
+func TestMinAllowedPartSize(t *testing.T) {
+	sizes := []struct {
+		isMin bool
+		size  int64
+	}{
+		// Test - 1 - within minimum part size.
+		{
+			true,
+			minPartSize + 1,
+		},
+		// Test - 2 - smaller than minimum part size.
+		{
+			false,
+			minPartSize - 1,
+		},
+	}
+
+	for i, s := range sizes {
+		isMin := isMinAllowedPartSize(s.size)
+		if isMin != s.isMin {
+			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMin, isMin)
+		}
+	}
+}
+
+// Tests maximum allowed part number.
+func TestMaxPartID(t *testing.T) {
+	sizes := []struct {
+		isMax bool
+		partN int
+	}{
+		// Test - 1 part number within max part number.
+		{
+			false,
+			maxPartID - 1,
+		},
+		// Test - 2 part number bigger than max part number.
+		{
+			true,
+			maxPartID + 1,
+		},
+	}
+
+	for i, s := range sizes {
+		isMax := isMaxPartID(s.partN)
+		if isMax != s.isMax {
+			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMax, isMax)
 		}
 	}
-	initGracefulShutdown(dummySuccess)
-	// Register two callbacks that return success
-	globalShutdownCBs.AddObjectLayerCB(func() errCode {
-		return exitSuccess
-	})
-	globalShutdownCBs.AddGenericCB(func() errCode {
-		return exitSuccess
-	})
-	globalShutdownSignalCh <- struct{}{}
 }