MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-02-03 09:55:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Avoid dangling deletes if disk not found (#16401)

Browse Source
This commit is contained in:
Poorna 2023-01-12 22:20:19 -08:00 committed by GitHub
parent c242e6c391
commit b22b39de96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cmd/erasure-healing.go
View File

@ -937,19 +937,22 @@ func isObjectDangling(metaArr []FileInfo, errs []error, dataErrs []error) (valid
// We can consider an object data not reliable // We can consider an object data not reliable
// when xl.meta is not found in read quorum disks. // when xl.meta is not found in read quorum disks.
// or when xl.meta is not readable in read quorum disks. // or when xl.meta is not readable in read quorum disks.
danglingErrsCount := func(cerrs []error) (int, int) { danglingErrsCount := func(cerrs []error) (int, int, int) {
var ( var (
notFoundCount int notFoundCount int
corruptedCount int corruptedCount int
diskNotFoundCount int
) )
for _, readErr := range cerrs { for _, readErr := range cerrs {
if errors.Is(readErr, errFileNotFound) || errors.Is(readErr, errFileVersionNotFound) { if errors.Is(readErr, errFileNotFound) || errors.Is(readErr, errFileVersionNotFound) {
notFoundCount++ notFoundCount++
} else if errors.Is(readErr, errFileCorrupt) { } else if errors.Is(readErr, errFileCorrupt) {
corruptedCount++ corruptedCount++
} else if errors.Is(readErr, errDiskNotFound) {
diskNotFoundCount++
} }
} }
return notFoundCount, corruptedCount return notFoundCount, corruptedCount, diskNotFoundCount
} }
ndataErrs := make([]error, len(dataErrs)) ndataErrs := make([]error, len(dataErrs))
@ -963,9 +966,12 @@ func isObjectDangling(metaArr []FileInfo, errs []error, dataErrs []error) (valid
} }
} }
notFoundMetaErrs, corruptedMetaErrs := danglingErrsCount(errs) notFoundMetaErrs, corruptedMetaErrs, driveNotFoundMetaErrs := danglingErrsCount(errs)
notFoundPartsErrs, corruptedPartsErrs := danglingErrsCount(ndataErrs) notFoundPartsErrs, corruptedPartsErrs, driveNotFoundPartsErrs := danglingErrsCount(ndataErrs)
if driveNotFoundMetaErrs > 0 || driveNotFoundPartsErrs > 0 {
return validMeta, false
}
for _, m := range metaArr { for _, m := range metaArr {
if m.IsValid() { if m.IsValid() {
validMeta = m validMeta = m