chore(all): replace map key deletion loop with clear() (#21082)

cmd/bucket-metadata-sys.go

@@ -647,9 +647,7 @@ func (sys *BucketMetadataSys) init(ctx context.Context, buckets []string) {
 // Reset the state of the BucketMetadataSys.
 func (sys *BucketMetadataSys) Reset() {
 	sys.Lock()
-	for k := range sys.metadataMap {
+	clear(sys.metadataMap)
-		delete(sys.metadataMap, k)
-	}
 	sys.Unlock()
 }
 

cmd/tier.go

@@ -491,13 +491,9 @@ func (config *TierConfigMgr) Reload(ctx context.Context, objAPI ObjectLayer) err
 	}
 
 	// Reset drivercache built using current config
-	for k := range config.drivercache {
+	clear(config.drivercache)
-		delete(config.drivercache, k)
-	}
 	// Remove existing tier configs
-	for k := range config.Tiers {
+	clear(config.Tiers)
-		delete(config.Tiers, k)
-	}
 	// Copy over the new tier configs
 	for tier, cfg := range newConfig.Tiers {
 		config.Tiers[tier] = cfg

cmd/xl-storage.go

@@ -3373,9 +3373,7 @@ func (s *xlStorage) CleanAbandonedData(ctx context.Context, volume string, path
 	}
 
 	// Clear and repopulate
-	for k := range foundDirs {
+	clear(foundDirs)
-		delete(foundDirs, k)
-	}
 
 	// Populate into map
 	for _, k := range dirs {

internal/grid/types.go

@@ -132,9 +132,7 @@ func (m *MSS) Msgsize() int {
 // NewMSS returns a new MSS.
 func NewMSS() *MSS {
 	m := MSS(mssPool.Get())
-	for k := range m {
+	clear(m)
-		delete(m, k)
-	}
 	return &m
 }
 

internal/s3select/csv/record.go

@@ -87,9 +87,7 @@ func (r *Record) Reset() {
 	if len(r.csvRecord) > 0 {
 		r.csvRecord = r.csvRecord[:0]
 	}
-	for k := range r.nameIndexMap {
+	clear(r.nameIndexMap)
-		delete(r.nameIndexMap, k)
-	}
 }
 
 // Clone the record.