From b00ac40c35437deb373d2200a324261e57701be0 Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Fri, 3 Jun 2016 05:39:47 +0530 Subject: [PATCH] XL/PutObject: Calculate size if not provided by the client and update xl.json with the correct size. (#1844) --- erasure-createfile.go | 11 ++++++----- xl-v1-multipart.go | 6 ++++-- xl-v1-object.go | 6 ++++-- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/erasure-createfile.go b/erasure-createfile.go index 0733cbc30..c12f273b4 100644 --- a/erasure-createfile.go +++ b/erasure-createfile.go @@ -28,7 +28,7 @@ import ( // erasureCreateFile - writes an entire stream by erasure coding to // all the disks, writes also calculate individual block's checksum // for future bit-rot protection. -func erasureCreateFile(disks []StorageAPI, volume string, path string, partName string, data io.Reader, eInfos []erasureInfo) (newEInfos []erasureInfo, err error) { +func erasureCreateFile(disks []StorageAPI, volume string, path string, partName string, data io.Reader, eInfos []erasureInfo) (newEInfos []erasureInfo, size int64, err error) { // Allocated blockSized buffer for reading. buf := make([]byte, blockSizeV1) hashWriters := newHashWriters(len(disks)) @@ -44,17 +44,18 @@ func erasureCreateFile(disks []StorageAPI, volume string, path string, partName break } if err != nil && err != io.ErrUnexpectedEOF { - return nil, err + return nil, 0, err } + size += int64(n) var blocks [][]byte // Returns encoded blocks. blocks, err = encodeData(buf[:n], eInfo.DataBlocks, eInfo.ParityBlocks) if err != nil { - return nil, err + return nil, 0, err } err = appendFile(disks, volume, path, blocks, eInfo.Distribution, hashWriters) if err != nil { - return nil, err + return nil, 0, err } } @@ -80,7 +81,7 @@ func erasureCreateFile(disks []StorageAPI, volume string, path string, partName } // Return newEInfos. - return newEInfos, nil + return newEInfos, size, nil } // encodeData - encodes incoming data buffer into diff --git a/xl-v1-multipart.go b/xl-v1-multipart.go index ff02d3a41..7becbe7ad 100644 --- a/xl-v1-multipart.go +++ b/xl-v1-multipart.go @@ -337,11 +337,13 @@ func (xl xlObjects) putObjectPart(bucket string, object string, uploadID string, } // Erasure code data and write across all disks. - newEInfos, err := erasureCreateFile(onlineDisks, minioMetaBucket, tmpPartPath, partSuffix, teeReader, eInfos) + newEInfos, n, err := erasureCreateFile(onlineDisks, minioMetaBucket, tmpPartPath, partSuffix, teeReader, eInfos) if err != nil { return "", toObjectErr(err, minioMetaBucket, tmpPartPath) } - + if size == -1 { + size = n + } // Calculate new md5sum. newMD5Hex := hex.EncodeToString(md5Writer.Sum(nil)) if md5Hex != "" { diff --git a/xl-v1-object.go b/xl-v1-object.go index 526212385..da40ea52d 100644 --- a/xl-v1-object.go +++ b/xl-v1-object.go @@ -296,11 +296,13 @@ func (xl xlObjects) PutObject(bucket string, object string, size int64, data io. } // Erasure code and write across all disks. - newEInfos, err := erasureCreateFile(onlineDisks, minioMetaBucket, tempErasureObj, "object1", teeReader, eInfos) + newEInfos, n, err := erasureCreateFile(onlineDisks, minioMetaBucket, tempErasureObj, "object1", teeReader, eInfos) if err != nil { return "", toObjectErr(err, minioMetaBucket, tempErasureObj) } - + if size == -1 { + size = n + } // Save additional erasureMetadata. modTime := time.Now().UTC()