MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 23:13:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix common Windows failure (#10397)

Browse Source 
The `getNonLoopBackIP` may grab an IP from an interface that
doesn't allow binding (on Windows), so this test consistently fails.

We exclude that specific error.
This commit is contained in:
Klaus Post 2020-09-01 10:11:15 -07:00 committed by GitHub
parent 1c085f7d1a
commit a89d6b8e3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/http/listener_test.go
View File

@ -186,6 +186,10 @@ func TestHTTPListenerStartClose(t *testing.T) {
testCase.serverAddrs, testCase.serverAddrs,
) )
if err != nil { if err != nil {
if strings.Contains(err.Error(), "The requested address is not valid in its context") {
// Ignore if IP is unbindable.
continue
}
t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err) t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err)
} }
@ -225,6 +229,10 @@ func TestHTTPListenerAddr(t *testing.T) {
testCase.serverAddrs, testCase.serverAddrs,
) )
if err != nil { if err != nil {
if strings.Contains(err.Error(), "The requested address is not valid in its context") {
// Ignore if IP is unbindable.
continue
}
t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err) t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err)
} }
@ -261,6 +269,10 @@ func TestHTTPListenerAddrs(t *testing.T) {
testCase.serverAddrs, testCase.serverAddrs,
) )
if err != nil { if err != nil {
if strings.Contains(err.Error(), "The requested address is not valid in its context") {
// Ignore if IP is unbindable.
continue
}
t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err) t.Fatalf("Test %d: error: expected = <nil>, got = %v", i+1, err)
} }