Refactor bucket delete and bucket policy (#5580)

This commit adds the bucket delete and bucket policy functionalities
to the browser.

Part of rewriting the browser code to follow best practices and
guidelines of React (issues #5409 and #5410)

The backend code has been modified by @krishnasrinivas to prevent
issue #4498 from occuring. The relevant changes have been made to the
code according to the latest commit and the unit tests in the backend.
This commit also addresses issue #5449.

browser/app/js/components/Policy.js

@@ -1,80 +0,0 @@
-import { READ_ONLY, WRITE_ONLY, READ_WRITE } from '../constants'
-
-import React, { Component, PropTypes } from 'react'
-import connect from 'react-redux/lib/components/connect'
-import classnames from 'classnames'
-import * as actions from '../actions'
-
-class Policy extends Component {
-  constructor(props, context) {
-    super(props, context)
-    this.state = {}
-  }
-
-  handlePolicyChange(e) {
-    this.setState({
-      policy: {
-        policy: e.target.value
-      }
-    })
-  }
-
-  removePolicy(e) {
-    e.preventDefault()
-    const {dispatch, currentBucket, prefix} = this.props
-    let newPrefix = prefix.replace(currentBucket + '/', '')
-    newPrefix = newPrefix.replace('*', '')
-    web.SetBucketPolicy({
-      bucketName: currentBucket,
-      prefix: newPrefix,
-      policy: 'none'
-    })
-      .then(() => {
-        dispatch(actions.setPolicies(this.props.policies.filter(policy => policy.prefix != prefix)))
-      })
-      .catch(e => dispatch(actions.showAlert({
-        type: 'danger',
-        message: e.message,
-      })))
-  }
-
-  render() {
-    const {policy, prefix, currentBucket} = this.props
-    let newPrefix = prefix.replace(currentBucket + '/', '')
-    newPrefix = newPrefix.replace('*', '')
-
-    if (!newPrefix)
-      newPrefix = '*'
-
-    return (
-      <div className="pmb-list">
-        <div className="pmbl-item">
-          { newPrefix }
-        </div>
-        <div className="pmbl-item">
-          <select className="form-control"
-            disabled
-            value={ policy }
-            onChange={ this.handlePolicyChange.bind(this) }>
-            <option value={ READ_ONLY }>
-              Read Only
-            </option>
-            <option value={ WRITE_ONLY }>
-              Write Only
-            </option>
-            <option value={ READ_WRITE }>
-              Read and Write
-            </option>
-          </select>
-        </div>
-        <div className="pmbl-item">
-          <button className="btn btn-block btn-danger" onClick={ this.removePolicy.bind(this) }>
-            Remove
-          </button>
-        </div>
-      </div>
-    )
-  }
-}
-
-export default connect(state => state)(Policy)

browser/app/js/components/PolicyInput.js

@@ -1,98 +0,0 @@
-import { READ_ONLY, WRITE_ONLY, READ_WRITE } from '../constants'
-import React, { Component, PropTypes } from 'react'
-import connect from 'react-redux/lib/components/connect'
-import classnames from 'classnames'
-import * as actions from '../actions'
-
-class PolicyInput extends Component {
-  componentDidMount() {
-    const {web, dispatch} = this.props
-    this.prefix.focus()
-    web.ListAllBucketPolicies({
-      bucketName: this.props.currentBucket
-    }).then(res => {
-      let policies = res.policies
-      if (policies) dispatch(actions.setPolicies(policies))
-    }).catch(err => {
-      dispatch(actions.showAlert({
-        type: 'danger',
-        message: err.message
-      }))
-    })
-  }
-
-  componentWillUnmount() {
-    const {dispatch} = this.props
-    dispatch(actions.setPolicies([]))
-  }
-
-  handlePolicySubmit(e) {
-    e.preventDefault()
-    const {web, dispatch, currentBucket} = this.props
-
-    let prefix = currentBucket + '/' + this.prefix.value
-    let policy = this.policy.value
-
-    if (!prefix.endsWith('*')) prefix = prefix + '*'
- 
-    let prefixAlreadyExists = this.props.policies.some(elem => prefix === elem.prefix)
-
-    if (prefixAlreadyExists) {
-      dispatch(actions.showAlert({
-       type: 'danger',
-       message: "Policy for this prefix already exists."
-      }))
-      return
-    }
-    
-    web.SetBucketPolicy({
-      bucketName: this.props.currentBucket,
-      prefix: this.prefix.value,
-      policy: this.policy.value
-    })
-      .then(() => {
-        dispatch(actions.setPolicies([{
-          policy, prefix
-        }, ...this.props.policies]))
-        this.prefix.value = ''
-      })
-      .catch(e => dispatch(actions.showAlert({
-        type: 'danger',
-        message: e.message,
-      })))
-  }
-
-  render() {
-    return (
-      <header className="pmb-list">
-        <div className="pmbl-item">
-          <input type="text"
-            ref={ prefix => this.prefix = prefix }
-            className="form-control"
-            placeholder="Prefix"
-            editable={ true } />
-        </div>
-        <div className="pmbl-item">
-          <select ref={ policy => this.policy = policy } className="form-control">
-            <option value={ READ_ONLY }>
-              Read Only
-            </option>
-            <option value={ WRITE_ONLY }>
-              Write Only
-            </option>
-            <option value={ READ_WRITE }>
-              Read and Write
-            </option>
-          </select>
-        </div>
-        <div className="pmbl-item">
-          <button className="btn btn-block btn-primary" onClick={ this.handlePolicySubmit.bind(this) }>
-            Add
-          </button>
-        </div>
-      </header>
-    )
-  }
-}
-
-export default connect(state => state)(PolicyInput)