MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-21 11:04:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: use browser redirect URL for IDP callback (#12689)

Browse Source 
if browser_redirect_url is set use that for IDP callback
automatically, if we do not have to set REDIRECT_URI
for OpenID callback URL.
This commit is contained in:
Harshavardhana 2021-07-12 15:21:07 -07:00 committed by GitHub
parent c438eda624
commit a655e7f820
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/common-main.go
View File

@ -428,6 +428,7 @@ func handleCommonEnvVars() {
err := fmt.Errorf("URL contains unexpected resources, expected URL to be of http(s)://minio.example.com format: %v", u) err := fmt.Errorf("URL contains unexpected resources, expected URL to be of http(s)://minio.example.com format: %v", u)
logger.Fatal(err, "Invalid MINIO_BROWSER_REDIRECT value is environment variable") logger.Fatal(err, "Invalid MINIO_BROWSER_REDIRECT value is environment variable")
} }
u.Path = "" // remove any path component such as `/`
globalBrowserRedirectURL = u globalBrowserRedirectURL = u
} }
} }

3
cmd/net.go
View File

@ -157,6 +157,9 @@ func sortIPs(ipList []string) []string {
} }
func getConsoleEndpoints() (consoleEndpoints []string) { func getConsoleEndpoints() (consoleEndpoints []string) {
if globalBrowserRedirectURL != nil {
return []string{globalBrowserRedirectURL.String()}
}
var ipList []string var ipList []string
if globalMinioConsoleHost == "" { if globalMinioConsoleHost == "" {
ipList = sortIPs(mustGetLocalIP4().ToSlice()) ipList = sortIPs(mustGetLocalIP4().ToSlice())