Better code coverage of handler-utils.go (#2746)

This commit is contained in:
Anis Elleuch 2016-09-20 18:40:46 +01:00 committed by Harshavardhana
parent 0a3448c8b6
commit a5066e8f76

View File

@ -33,6 +33,15 @@ func TestIsValidLocationContraint(t *testing.T) {
}
defer removeAll(path)
// Test with corrupted XML
malformedReq := &http.Request{
Body: ioutil.NopCloser(bytes.NewBuffer([]byte("<>"))),
ContentLength: int64(len("<>")),
}
if err := isValidLocationConstraint(malformedReq); err != ErrMalformedXML {
t.Fatal("Unexpected error: ", err)
}
// generates the input request with XML bucket configuration set to the request body.
createExpectedRequest := func(req *http.Request, location string) (*http.Request, error) {
createBucketConfig := createBucketLocationConfiguration{}
@ -96,6 +105,16 @@ func TestExtractMetadataHeaders(t *testing.T) {
},
metadata: map[string]string{},
},
// Validate if there are no keys to extract.
{
header: http.Header{
"X-Amz-Meta-Appid": []string{"amz-meta"},
"X-Minio-Meta-Appid": []string{"minio-meta"},
},
metadata: map[string]string{
"X-Amz-Meta-Appid": "amz-meta",
"X-Minio-Meta-Appid": "minio-meta"},
},
}
// Validate if the extracting headers.