MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-06 12:50:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: ignore transient errors in read path (#18006)

Browse Source 
Errors such as

```
returned an error (context deadline exceeded) (*fmt.wrapError)
```

```
(msgp: too few bytes left to read object) (*fmt.wrapError)
```
This commit is contained in:
Harshavardhana 2023-09-11 15:29:59 -07:00 committed by GitHub
parent 41de53996b
commit 9f7044aed0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/erasure-object.go
View File

@ -46,6 +46,7 @@ import (
"github.com/minio/pkg/v2/mimedb" "github.com/minio/pkg/v2/mimedb"
"github.com/minio/pkg/v2/sync/errgroup" "github.com/minio/pkg/v2/sync/errgroup"
"github.com/minio/pkg/v2/wildcard" "github.com/minio/pkg/v2/wildcard"
"github.com/tinylib/msgp/msgp"
uatomic "go.uber.org/atomic" uatomic "go.uber.org/atomic"
) )
@ -578,6 +579,9 @@ func readAllXL(ctx context.Context, disks []StorageAPI, bucket, object string, r
errFileVersionNotFound, errFileVersionNotFound,
io.ErrUnexpectedEOF, // some times we would read without locks, ignore these errors io.ErrUnexpectedEOF, // some times we would read without locks, ignore these errors
io.EOF, // some times we would read without locks, ignore these errors io.EOF, // some times we would read without locks, ignore these errors
msgp.ErrShortBytes,
context.DeadlineExceeded,
context.Canceled,
} }
ignoredErrs = append(ignoredErrs, objectOpIgnoredErrs...) ignoredErrs = append(ignoredErrs, objectOpIgnoredErrs...)

1
cmd/erasure.go
View File

@ -182,7 +182,6 @@ func getDisksInfo(disks []StorageAPI, endpoints []Endpoint) (disksInfo []madmin.
DiskIndex: endpoints[index].DiskIdx, DiskIndex: endpoints[index].DiskIdx,
} }
if disks[index] == OfflineDisk { if disks[index] == OfflineDisk {
logger.LogOnceIf(GlobalContext, fmt.Errorf("%s: %s", errDiskNotFound, endpoints[index]), "get-disks-info-offline-"+di.Endpoint)
di.State = diskErrToDriveState(errDiskNotFound) di.State = diskErrToDriveState(errDiskNotFound)
disksInfo[index] = di disksInfo[index] = di
return nil return nil