mirror of
https://github.com/minio/minio.git
synced 2025-11-06 20:33:07 -05:00
Extend further validation of config values (#8469)
- This PR allows config KVS to be validated properly without being affected by ENV overrides, rejects invalid values during set operation - Expands unit tests and refactors the error handling for notification targets, returns error instead of ignoring targets for invalid KVS - Does all the prep-work for implementing safe-mode style operation for MinIO server, introduces a new global variable to toggle safe mode based operations NOTE: this PR itself doesn't provide safe mode operations
This commit is contained in:
committed by
kannappanr
parent
599aae5ba6
commit
9e7a3e6adc
@@ -50,12 +50,11 @@ func printStartupMessage(apiEndPoints []string) {
|
||||
|
||||
strippedAPIEndpoints := stripStandardPorts(apiEndPoints)
|
||||
// If cache layer is enabled, print cache capacity.
|
||||
cacheObjectAPI := newCacheObjectsFn()
|
||||
if cacheObjectAPI != nil {
|
||||
printCacheStorageInfo(cacheObjectAPI.StorageInfo(context.Background()))
|
||||
if globalCacheObjectAPI != nil {
|
||||
printCacheStorageInfo(globalCacheObjectAPI.StorageInfo(context.Background()))
|
||||
}
|
||||
// Object layer is initialized then print StorageInfo.
|
||||
objAPI := newObjectLayerFn()
|
||||
objAPI := globalObjectAPI
|
||||
if objAPI != nil {
|
||||
printStorageInfo(objAPI.StorageInfo(context.Background()))
|
||||
}
|
||||
@@ -97,7 +96,7 @@ func stripStandardPorts(apiEndpoints []string) (newAPIEndpoints []string) {
|
||||
newAPIEndpoints = make([]string, len(apiEndpoints))
|
||||
// Check all API endpoints for standard ports and strip them.
|
||||
for i, apiEndpoint := range apiEndpoints {
|
||||
u, err := xnet.ParseURL(apiEndpoint)
|
||||
u, err := xnet.ParseHTTPURL(apiEndpoint)
|
||||
if err != nil {
|
||||
newAPIEndpoints[i] = apiEndpoint
|
||||
continue
|
||||
|
||||
Reference in New Issue
Block a user