mirror of
https://github.com/minio/minio.git
synced 2025-12-08 16:53:11 -05:00
Extend further validation of config values (#8469)
- This PR allows config KVS to be validated properly without being affected by ENV overrides, rejects invalid values during set operation - Expands unit tests and refactors the error handling for notification targets, returns error instead of ignoring targets for invalid KVS - Does all the prep-work for implementing safe-mode style operation for MinIO server, introduces a new global variable to toggle safe mode based operations NOTE: this PR itself doesn't provide safe mode operations
This commit is contained in:
committed by
kannappanr
parent
599aae5ba6
commit
9e7a3e6adc
@@ -1098,10 +1098,10 @@ func (sys *NotificationSys) NetworkInfo() []madmin.ServerNetworkHardwareInfo {
|
||||
}
|
||||
|
||||
// NewNotificationSys - creates new notification system object.
|
||||
func NewNotificationSys(cfg config.Config, endpoints EndpointList) *NotificationSys {
|
||||
func NewNotificationSys(cfg config.Config, endpoints EndpointList) (*NotificationSys, error) {
|
||||
targetList, err := notify.GetNotificationTargets(cfg, GlobalServiceDoneCh, globalRootCAs)
|
||||
if err != nil {
|
||||
logger.FatalIf(err, "Unable to start notification sub system")
|
||||
return nil, config.Errorf("Unable to start notification sub system: %s", err)
|
||||
}
|
||||
|
||||
remoteHosts := getRemoteHosts(endpoints)
|
||||
@@ -1113,7 +1113,7 @@ func NewNotificationSys(cfg config.Config, endpoints EndpointList) *Notification
|
||||
bucketRulesMap: make(map[string]event.RulesMap),
|
||||
bucketRemoteTargetRulesMap: make(map[string]map[event.TargetID]event.RulesMap),
|
||||
peerClients: remoteClients,
|
||||
}
|
||||
}, nil
|
||||
}
|
||||
|
||||
type eventArgs struct {
|
||||
|
||||
Reference in New Issue
Block a user