mirror of
https://github.com/minio/minio.git
synced 2025-11-22 18:47:43 -05:00
Extend further validation of config values (#8469)
- This PR allows config KVS to be validated properly without being affected by ENV overrides, rejects invalid values during set operation - Expands unit tests and refactors the error handling for notification targets, returns error instead of ignoring targets for invalid KVS - Does all the prep-work for implementing safe-mode style operation for MinIO server, introduces a new global variable to toggle safe mode based operations NOTE: this PR itself doesn't provide safe mode operations
This commit is contained in:
committed by
kannappanr
parent
599aae5ba6
commit
9e7a3e6adc
@@ -206,7 +206,9 @@ func StartGateway(ctx *cli.Context, gw Gateway) {
|
||||
srvCfg := newServerConfig()
|
||||
|
||||
// Override any values from ENVs.
|
||||
lookupConfigs(srvCfg)
|
||||
if err := lookupConfigs(srvCfg); err != nil {
|
||||
logger.FatalIf(err, "Unable to initialize server config")
|
||||
}
|
||||
|
||||
// hold the mutex lock before a new config is assigned.
|
||||
globalServerConfigMu.Lock()
|
||||
@@ -232,7 +234,7 @@ func StartGateway(ctx *cli.Context, gw Gateway) {
|
||||
// Create a new config system.
|
||||
globalConfigSys = NewConfigSys()
|
||||
|
||||
// Load globalServerConfig from etcd
|
||||
// Load globalServerConfig from disk
|
||||
logger.LogIf(context.Background(), globalConfigSys.Init(newObject))
|
||||
|
||||
// Start watching disk for reloading config, this
|
||||
@@ -267,7 +269,10 @@ func StartGateway(ctx *cli.Context, gw Gateway) {
|
||||
globalLifecycleSys = NewLifecycleSys()
|
||||
|
||||
// Create new notification system.
|
||||
globalNotificationSys = NewNotificationSys(globalServerConfig, globalEndpoints)
|
||||
globalNotificationSys, err = NewNotificationSys(globalServerConfig, globalEndpoints)
|
||||
if err != nil {
|
||||
logger.FatalIf(err, "Unable to initialize notification system")
|
||||
}
|
||||
|
||||
// Verify if object layer supports
|
||||
// - encryption
|
||||
|
||||
Reference in New Issue
Block a user