Remove B2 gateway implementation (#9547)

S3 is now natively supported by B2 cloud storage provider
there is no reason to use specialized gateway for B2 anymore,
our current S3 gateway with caching would work with B2.

Resolves #8584

cmd/gateway/b2/gateway-b2_test.go

@@ -1,146 +0,0 @@
-/*
- * MinIO Cloud Storage, (C) 2017 MinIO, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package b2
-
-import (
-	"fmt"
-	"testing"
-
-	minio "github.com/minio/minio/cmd"
-)
-
-// Test b2 object error.
-func TestB2ObjectError(t *testing.T) {
-	testCases := []struct {
-		params      []string
-		b2Err       error
-		expectedErr error
-	}{
-		{
-			[]string{}, nil, nil,
-		},
-		{
-			[]string{}, fmt.Errorf("Not *Error"), fmt.Errorf("Not *Error"),
-		},
-		{
-			[]string{}, fmt.Errorf("Non B2 Error"), fmt.Errorf("Non B2 Error"),
-		},
-	}
-
-	for i, testCase := range testCases {
-		actualErr := b2ToObjectError(testCase.b2Err, testCase.params...)
-		if actualErr != nil {
-			if actualErr.Error() != testCase.expectedErr.Error() {
-				t.Errorf("Test %d: Expected %s, got %s", i+1, testCase.expectedErr, actualErr)
-			}
-		}
-	}
-}
-
-// Test b2 msg code to object error.
-func TestB2MsgCodeToObjectError(t *testing.T) {
-	testCases := []struct {
-		params      []string
-		code        int
-		msgCode     string
-		msg         string
-		expectedErr error
-	}{
-		{
-			[]string{"bucket"},
-			1,
-			"duplicate_bucket_name",
-			"",
-			minio.BucketAlreadyOwnedByYou{
-				Bucket: "bucket",
-			},
-		},
-		{
-			[]string{"bucket"},
-			1,
-			"bad_request",
-			"",
-			minio.BucketNotFound{
-				Bucket: "bucket",
-			},
-		},
-		{
-			[]string{"bucket", "object"},
-			1,
-			"bad_request",
-			"",
-			minio.ObjectNameInvalid{
-				Bucket: "bucket",
-				Object: "object",
-			},
-		},
-		{
-			[]string{"bucket"},
-			1,
-			"bad_bucket_id",
-			"",
-			minio.BucketNotFound{Bucket: "bucket"},
-		},
-		{
-			[]string{"bucket", "object"},
-			1,
-			"file_not_present",
-			"",
-			minio.ObjectNotFound{
-				Bucket: "bucket",
-				Object: "object",
-			},
-		},
-		{
-			[]string{"bucket", "object"},
-			1,
-			"not_found",
-			"",
-			minio.ObjectNotFound{
-				Bucket: "bucket",
-				Object: "object",
-			},
-		},
-		{
-			[]string{"bucket"},
-			1,
-			"cannot_delete_non_empty_bucket",
-			"",
-			minio.BucketNotEmpty{
-				Bucket: "bucket",
-			},
-		},
-		{
-			[]string{"bucket", "object", "uploadID"},
-			1,
-			"",
-			"No active upload for",
-			minio.InvalidUploadID{
-				UploadID: "uploadID",
-			},
-		},
-	}
-
-	for i, testCase := range testCases {
-		actualErr := b2MsgCodeToObjectError(testCase.code, testCase.msgCode, testCase.msg, testCase.params...)
-		if actualErr != nil {
-			if actualErr.Error() != testCase.expectedErr.Error() {
-				t.Errorf("Test %d: Expected %s, got %s", i+1, testCase.expectedErr, actualErr)
-			}
-		}
-	}
-}

cmd/gateway/gateway.go

@@ -1,5 +1,5 @@
 /*
- * MinIO Cloud Storage, (C) 2017 MinIO, Inc.
+ * MinIO Cloud Storage, (C) 2017-2020 MinIO, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,15 +17,23 @@
 package gateway
 
 import (
-	// Import all gateways.
-	_ "github.com/minio/minio/cmd/gateway/azure"
-	_ "github.com/minio/minio/cmd/gateway/gcs"
-	_ "github.com/minio/minio/cmd/gateway/hdfs"
+	// Import all gateways please keep the order
+
+	// NAS
 	_ "github.com/minio/minio/cmd/gateway/nas"
+
+	// Azure
+	_ "github.com/minio/minio/cmd/gateway/azure"
+
+	// S3
 	_ "github.com/minio/minio/cmd/gateway/s3"
 
-	// B2 is specifically kept here to avoid re-ordering by goimports,
-	// please ask on github.com/minio/minio/issues before changing this.
-	_ "github.com/minio/minio/cmd/gateway/b2"
-	// Add your gateway here.
+	// HDFS
+	_ "github.com/minio/minio/cmd/gateway/hdfs"
+
+	// GCS (use only if you must, GCS already supports S3 API)
+	_ "github.com/minio/minio/cmd/gateway/gcs"
+	// gateway functionality is frozen, no new gateways are being implemented
+	// or considered for upstream inclusion at this point in time. if needed
+	// please keep a fork of the project.
 )