MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-02-04 02:15:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove stable sort usage when not needed (#5586)

Browse Source 
Stable sort is needed when we are sorting based on two or more
distinct elements. When equal elements are indistinguishable,
such as with integers, or more generally, any data where the
entire element is the key like `PartNumber`, stability is not
an issue.
This commit is contained in:
Harshavardhana 2018-02-27 19:03:00 -08:00 committed by Nitish Tiwari
parent 6b3db7556a
commit 9af254a82f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/fs-v1-multipart.go
View File

@ -417,7 +417,7 @@ func (fs *FSObjects) ListObjectParts(bucket, object, uploadID string, partNumber
for partNumber, etag := range partsMap { for partNumber, etag := range partsMap {
parts = append(parts, PartInfo{PartNumber: partNumber, ETag: etag}) parts = append(parts, PartInfo{PartNumber: partNumber, ETag: etag})
} }
sort.SliceStable(parts, func(i int, j int) bool { sort.Slice(parts, func(i int, j int) bool {
return parts[i].PartNumber < parts[j].PartNumber return parts[i].PartNumber < parts[j].PartNumber
}) })
i := 0 i := 0

2
cmd/gateway/azure/gateway-azure.go
View File

@ -806,7 +806,7 @@ func (a *azureObjects) ListObjectParts(bucket, object, uploadID string, partNumb
for _, part := range partsMap { for _, part := range partsMap {
parts = append(parts, part) parts = append(parts, part)
} }
sort.SliceStable(parts, func(i int, j int) bool { sort.Slice(parts, func(i int, j int) bool {
return parts[i].PartNumber < parts[j].PartNumber return parts[i].PartNumber < parts[j].PartNumber
}) })
partsCount := 0 partsCount := 0