simplify logger time and avoid possible crashes (#13986)

time.Format() is not necessary prematurely for JSON
marshalling, since JSON marshalling indeed defaults
to RFC3339Nano.

This also ensures the 'time' is remembered until its
logged and it is the same time when the 'caller'
invoked 'log' functions.

internal/logger/message/audit/entry.go

@@ -31,10 +31,10 @@ const Version = "1"
 
 // Entry - audit entry logs.
 type Entry struct {
-	Version      string `json:"version"`
-	DeploymentID string `json:"deploymentid,omitempty"`
-	Time         string `json:"time"`
-	Trigger      string `json:"trigger"`
+	Version      string    `json:"version"`
+	DeploymentID string    `json:"deploymentid,omitempty"`
+	Time         time.Time `json:"time"`
+	Trigger      string    `json:"trigger"`
 	API          struct {
 		Name            string `json:"name,omitempty"`
 		Bucket          string `json:"bucket,omitempty"`
@@ -61,7 +61,7 @@ func NewEntry(deploymentID string) Entry {
 	return Entry{
 		Version:      Version,
 		DeploymentID: deploymentID,
-		Time:         time.Now().UTC().Format(time.RFC3339Nano),
+		Time:         time.Now().UTC(),
 	}
 }
 

internal/logger/message/log/entry.go

@@ -17,7 +17,10 @@
 
 package log
 
-import "strings"
+import (
+	"strings"
+	"time"
+)
 
 // Args - defines the arguments for the API.
 type Args struct {
@@ -41,17 +44,17 @@ type API struct {
 
 // Entry - defines fields and values of each log entry.
 type Entry struct {
-	DeploymentID string `json:"deploymentid,omitempty"`
-	Level        string `json:"level"`
-	LogKind      string `json:"errKind"`
-	Time         string `json:"time"`
-	API          *API   `json:"api,omitempty"`
-	RemoteHost   string `json:"remotehost,omitempty"`
-	Host         string `json:"host,omitempty"`
-	RequestID    string `json:"requestID,omitempty"`
-	UserAgent    string `json:"userAgent,omitempty"`
-	Message      string `json:"message,omitempty"`
-	Trace        *Trace `json:"error,omitempty"`
+	DeploymentID string    `json:"deploymentid,omitempty"`
+	Level        string    `json:"level"`
+	LogKind      string    `json:"errKind"`
+	Time         time.Time `json:"time"`
+	API          *API      `json:"api,omitempty"`
+	RemoteHost   string    `json:"remotehost,omitempty"`
+	Host         string    `json:"host,omitempty"`
+	RequestID    string    `json:"requestID,omitempty"`
+	UserAgent    string    `json:"userAgent,omitempty"`
+	Message      string    `json:"message,omitempty"`
+	Trace        *Trace    `json:"error,omitempty"`
 }
 
 // Info holds console log messages