MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-24 11:37:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

lifecycle: Accept document without expiration (#10348)

Browse Source
This commit is contained in:
Anis Elleuch
2020-08-25 20:38:59 +01:00
committed by GitHub
parent d19b434ffc
commit 9acdeab73d
4 changed files with 62 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/bucket/lifecycle/expiration_test.go
View File

@@ -78,7 +78,7 @@ func TestInvalidExpiration(t *testing.T) {
{ // Expiration with neither number of days nor a date
inputXML: `<Expiration>
</Expiration>`,
expectedErr: errLifecycleInvalidExpiration,
expectedErr: errXMLNotWellFormed,
},
{ // Expiration with both number of days and a date
inputXML: `<Expiration>
@@ -87,6 +87,13 @@ func TestInvalidExpiration(t *testing.T) {
</Expiration>`,
expectedErr: errLifecycleInvalidExpiration,
},
{ // Expiration with both ExpiredObjectDeleteMarker and days
inputXML: `<Expiration>
<Days>3</Days>
<ExpiredObjectDeleteMarker>false</ExpiredObjectDeleteMarker>
</Expiration>`,
expectedErr: errLifecycleInvalidDeleteMarker,
},
}
for i, tc := range validationTestCases {
t.Run(fmt.Sprintf("Test %d", i+1), func(t *testing.T) {
@@ -98,7 +105,7 @@ func TestInvalidExpiration(t *testing.T) {
err = expiration.Validate()
if err != tc.expectedErr {
t.Fatalf("%d: %v", i+1, err)
t.Fatalf("%d: got: %v, expected: %v", i+1, err, tc.expectedErr)
}
})
}