MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

disconnected returns, an unexpected error to List() returning 500s (#18959)

Browse Source 
provide the error string appropriately so that the
matching of error types works.

Also add a string based fallback for the said error.
This commit is contained in:
Harshavardhana 2024-02-03 01:04:33 -08:00 committed by GitHub
parent 63bf5f42a1
commit 960d604013
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/storage-rest-client.go
View File

@ -148,6 +148,8 @@ func toStorageErr(err error) error {
return errDiskOngoingReq return errDiskOngoingReq
case grid.ErrUnknownHandler.Error(): case grid.ErrUnknownHandler.Error():
return errInconsistentDisk return errInconsistentDisk
case grid.ErrDisconnected.Error():
return errDiskNotFound
} }
return err return err
} }

2
internal/grid/connection.go
View File

@ -1374,7 +1374,7 @@ func (c *Connection) handleDisconnectClientMux(m message) {
if m.Flags&FlagPayloadIsErr != 0 { if m.Flags&FlagPayloadIsErr != 0 {
v.error(RemoteErr(m.Payload)) v.error(RemoteErr(m.Payload))
} else { } else {
v.error("remote disconnected") v.error(ErrDisconnected)
} }
return return
} }

2
internal/grid/grid.go
View File

@ -30,7 +30,7 @@ import (
) )
// ErrDisconnected is returned when the connection to the remote has been lost during the call. // ErrDisconnected is returned when the connection to the remote has been lost during the call.
var ErrDisconnected = errors.New("remote disconnected") var ErrDisconnected = RemoteErr("remote disconnected")
const ( const (
// minBufferSize is the minimum buffer size. // minBufferSize is the minimum buffer size.