MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-25 04:33:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid allocs for MRF on-disk header (#18425)

Browse Source
This commit is contained in:
Krishnan Parthasarathi 2023-11-10 19:54:46 -08:00 committed by GitHub
parent 54721b7c7b
commit 9569a85cee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
cmd/bucket-replication.go
View File

@ -3187,12 +3187,16 @@ func (p *ReplicationPool) queueMRFSave(entry MRFReplicateEntry) {
} }
} }
func (p *ReplicationPool) persistToDrive(ctx context.Context, v MRFReplicateEntries, data []byte) { func (p *ReplicationPool) persistToDrive(ctx context.Context, v MRFReplicateEntries) {
newReader := func() io.ReadCloser { newReader := func() io.ReadCloser {
r, w := io.Pipe() r, w := io.Pipe()
go func() { go func() {
// Initialize MRF meta header.
var data [4]byte
binary.LittleEndian.PutUint16(data[0:2], mrfMetaFormat)
binary.LittleEndian.PutUint16(data[2:4], mrfMetaVersion)
mw := msgp.NewWriter(w) mw := msgp.NewWriter(w)
n, err := mw.Write(data) n, err := mw.Write(data[:])
if err != nil { if err != nil {
w.CloseWithError(err) w.CloseWithError(err)
return return
@ -3230,15 +3234,10 @@ func (p *ReplicationPool) saveMRFEntries(ctx context.Context, entries map[string
v := MRFReplicateEntries{ v := MRFReplicateEntries{
Entries: entries, Entries: entries,
Version: mrfMetaVersionV1, Version: mrfMetaVersion,
} }
data := make([]byte, 4, v.Msgsize()+4)
// Initialize the resync meta header. p.persistToDrive(ctx, v)
binary.LittleEndian.PutUint16(data[0:2], mrfMetaFormat)
binary.LittleEndian.PutUint16(data[2:4], mrfMetaVersion)
p.persistToDrive(ctx, v, data)
} }
// load mrf entries from disk // load mrf entries from disk