MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-20 18:06:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

NewUX: On filename click, select file instead of downloading (#6023)

Browse Source 
This commit has been done according to @abperiasamy's feedback as we
are going to reserve the click on file icon to open the preview modal
in the future.

Also, when the user now selects a single file, the file itself is
downloaded instead of a .zip file containing the file.

Fixes #6019
This commit is contained in:
Kaan Kabalak
2018-06-07 12:02:02 -07:00
committed by Dee Koder
parent 617a6d8e47
commit 94ec6f374e
8 changed files with 102 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
browser/app/js/objects/__tests__/ObjectItem.test.js
View File

@@ -28,33 +28,22 @@ describe("ObjectItem", () => {
expect(wrapper.prop("data-type")).toBe("image")
})
it("should call onClick when the object isclicked", () => {
const onClick = jest.fn()
const wrapper = shallow(<ObjectItem name={"test"} onClick={onClick} />)
wrapper.find("a").simulate("click", { preventDefault: jest.fn() })
expect(onClick).toHaveBeenCalled()
})
it("should call checkObject when the object/prefix is checked", () => {
it("should call checkObject when the object is selected", () => {
const checkObject = jest.fn()
const wrapper = shallow(
<ObjectItem name={"test"} checked={false} checkObject={checkObject} />
)
wrapper.find("input[type='checkbox']").simulate("change")
const wrapper = shallow(<ObjectItem name={"test"} checked={false} checkObject={checkObject} />)
wrapper.find("a").simulate("click", { preventDefault: jest.fn() })
expect(checkObject).toHaveBeenCalledWith("test")
})
it("should render checked checkbox", () => {
it("should render highlighted row when object is selected", () => {
const wrapper = shallow(<ObjectItem name={"test"} checked={true} />)
expect(wrapper.find("input[type='checkbox']").prop("checked")).toBeTruthy()
expect(wrapper.find(".fesl-row").hasClass("fesl-row-selected")).toBeTruthy()
})
it("should call uncheckObject when the object/prefix is unchecked", () => {
it("should call uncheckObject when the object is deselected", () => {
const uncheckObject = jest.fn()
const wrapper = shallow(
<ObjectItem name={"test"} checked={true} uncheckObject={uncheckObject} />
)
wrapper.find("input[type='checkbox']").simulate("change")
const wrapper = shallow(<ObjectItem name={"test"} checked={true} uncheckObject={uncheckObject} />)
wrapper.find("a").simulate("click", { preventDefault: jest.fn() })
expect(uncheckObject).toHaveBeenCalledWith("test")
})
})