tests: Add test for S3 API error codes (#16705)

This commit is contained in:
Anis Elleuch 2023-02-25 03:36:29 +01:00 committed by GitHub
parent 3f81cd1b22
commit 94c6cb1323
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 233 additions and 221 deletions

View File

@ -165,7 +165,6 @@ const (
ErrMalformedDate ErrMalformedDate
ErrMalformedPresignedDate ErrMalformedPresignedDate
ErrMalformedCredentialDate ErrMalformedCredentialDate
ErrMalformedCredentialRegion
ErrMalformedExpires ErrMalformedExpires
ErrNegativeExpires ErrNegativeExpires
ErrAuthHeaderEmpty ErrAuthHeaderEmpty
@ -244,8 +243,6 @@ const (
// Add new extended error codes here. // Add new extended error codes here.
// MinIO extended errors. // MinIO extended errors.
ErrReadQuorum
ErrWriteQuorum
ErrStorageFull ErrStorageFull
ErrRequestBodyParse ErrRequestBodyParse
ErrObjectExistsAsDirectory ErrObjectExistsAsDirectory
@ -412,6 +409,8 @@ const (
ErrPostPolicyConditionInvalidFormat ErrPostPolicyConditionInvalidFormat
ErrInvalidChecksum ErrInvalidChecksum
apiErrCodeEnd // This is used only for the testing code
) )
type errorCodeMap map[APIErrorCode]APIError type errorCodeMap map[APIErrorCode]APIError

View File

@ -80,3 +80,19 @@ func TestAPIErrCode(t *testing.T) {
} }
} }
} }
// Check if an API error is properly defined
func TestAPIErrCodeDefinition(t *testing.T) {
for errAPI := ErrNone + 1; errAPI < apiErrCodeEnd; errAPI++ {
errCode, ok := errorCodes[errAPI]
if !ok {
t.Fatal(errAPI, "error code is not defined in the API error code table")
}
if errCode.Code == "" {
t.Fatal(errAPI, "error code has an empty XML code")
}
if errCode.HTTPStatusCode == 0 {
t.Fatal(errAPI, "error code has a zero HTTP status code")
}
}
}

File diff suppressed because one or more lines are too long