MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 12:52:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

allow dynamically changing max_object_versions per object (#19265)

Browse Source
This commit is contained in:
Harshavardhana
2024-03-14 18:07:19 -07:00
committed by GitHub
parent 485298b680
commit 93fb7d62d8
4 changed files with 42 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
cmd/xl-storage-format-v2.go
View File

@@ -25,7 +25,6 @@ import (
"fmt"
"io"
"sort"
"strconv"
"strings"
"sync"
"time"
@@ -38,31 +37,12 @@ import (
"github.com/minio/minio/internal/config/storageclass"
xhttp "github.com/minio/minio/internal/http"
"github.com/minio/minio/internal/logger"
"github.com/minio/pkg/v2/env"
"github.com/tinylib/msgp/msgp"
)
// Reject creating new versions when a single object is cross maxObjectVersions
var maxObjectVersions = 10000
func init() {
v := env.Get("_MINIO_OBJECT_MAX_VERSIONS", "")
if v != "" {
maxv, err := strconv.Atoi(v)
if err != nil {
logger.Info("invalid _MINIO_OBJECT_MAX_VERSIONS value: %s, defaulting to '10000'", v)
maxObjectVersions = 10000
} else {
if maxv < 10 {
logger.Info("invalid _MINIO_OBJECT_MAX_VERSIONS value: %s, minimum allowed is '10' defaulting to '10000'", v)
maxObjectVersions = 10000
} else {
maxObjectVersions = maxv
}
}
}
}
var (
// XL header specifies the format
xlHeader = [4]byte{'X', 'L', '2', ' '}
@@ -1112,7 +1092,7 @@ func (x *xlMetaV2) addVersion(ver xlMetaV2Version) error {
}
// returns error if we have exceeded maxObjectVersions
if len(x.versions)+1 > maxObjectVersions {
if len(x.versions)+1 > globalAPIConfig.getObjectMaxVersions() {
return errMaxVersionsExceeded
}