MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 21:02:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

tests: Do not allow forced type asserts (#20905)

Browse Source
This commit is contained in:
Klaus Post
2025-02-18 08:25:55 -08:00
committed by GitHub
parent aeabac9181
commit 90f5e1e5f6
100 changed files with 371 additions and 358 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
internal/jwt/parser.go
View File

@@ -30,13 +30,13 @@ import (
"errors"
"fmt"
"hash"
"sync"
"time"
"github.com/buger/jsonparser"
"github.com/dustin/go-humanize"
jwtgo "github.com/golang-jwt/jwt/v4"
jsoniter "github.com/json-iterator/go"
"github.com/minio/minio/internal/bpool"
)
// SigningMethodHMAC - Implements the HMAC-SHA family of signing methods signing methods
@@ -44,7 +44,7 @@ import (
type SigningMethodHMAC struct {
Name string
Hash crypto.Hash
HasherPool sync.Pool
HasherPool bpool.Pool[hash.Hash]
}
// Specific instances for HS256, HS384, HS512
@@ -57,13 +57,13 @@ var (
const base64BufferSize = 64 * humanize.KiByte
var (
base64BufPool sync.Pool
base64BufPool bpool.Pool[*[]byte]
hmacSigners []*SigningMethodHMAC
)
func init() {
base64BufPool = sync.Pool{
New: func() interface{} {
base64BufPool = bpool.Pool[*[]byte]{
New: func() *[]byte {
buf := make([]byte, base64BufferSize)
return &buf
},
@@ -76,7 +76,7 @@ func init() {
}
for i := range hmacSigners {
h := hmacSigners[i].Hash
hmacSigners[i].HasherPool.New = func() interface{} {
hmacSigners[i].HasherPool.New = func() hash.Hash {
return h.New()
}
}
@@ -89,13 +89,13 @@ func (s *SigningMethodHMAC) HashBorrower() HashBorrower {
// HashBorrower keeps track of borrowed hashers and allows to return them all.
type HashBorrower struct {
pool *sync.Pool
pool *bpool.Pool[hash.Hash]
borrowed []hash.Hash
}
// Borrow a single hasher.
func (h *HashBorrower) Borrow() hash.Hash {
hasher := h.pool.Get().(hash.Hash)
hasher := h.pool.Get()
h.borrowed = append(h.borrowed, hasher)
hasher.Reset()
return hasher
@@ -323,10 +323,10 @@ func ParseWithStandardClaims(tokenStr string, claims *StandardClaims, key []byte
return jwtgo.NewValidationError("no key was provided.", jwtgo.ValidationErrorUnverifiable)
}
bufp := base64BufPool.Get().(*[]byte)
bufp := base64BufPool.Get()
defer base64BufPool.Put(bufp)
tokenBuf := base64BufPool.Get().(*[]byte)
tokenBuf := base64BufPool.Get()
defer base64BufPool.Put(tokenBuf)
token := *tokenBuf
@@ -419,10 +419,10 @@ func ParseWithClaims(tokenStr string, claims *MapClaims, fn func(*MapClaims) ([]
return jwtgo.NewValidationError("no Keyfunc was provided.", jwtgo.ValidationErrorUnverifiable)
}
bufp := base64BufPool.Get().(*[]byte)
bufp := base64BufPool.Get()
defer base64BufPool.Put(bufp)
tokenBuf := base64BufPool.Get().(*[]byte)
tokenBuf := base64BufPool.Get()
defer base64BufPool.Put(tokenBuf)
token := *tokenBuf