MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

validate keys before updating for IAM user (#7720)

Browse Source 
New secretkey should be validated before updating
it on the config.

Fixes #7715
This commit is contained in:
Kanagaraj M 2019-05-30 17:44:35 +05:30 committed by kannappanr
parent 8528017ad3
commit 900cc27b51
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/web-handlers.go
View File

@ -842,12 +842,17 @@ func (web *webAPIHandlers) SetAuth(r *http.Request, args *SetAuthArgs, reply *Se
return errIncorrectCreds return errIncorrectCreds
} }
err := globalIAMSys.SetUserSecretKey(claims.Subject, args.NewSecretKey) creds, err := auth.CreateCredentials(claims.Subject, args.NewSecretKey)
if err != nil { if err != nil {
return toJSONError(err) return toJSONError(err)
} }
reply.Token, err = authenticateWeb(claims.Subject, args.NewSecretKey) err = globalIAMSys.SetUserSecretKey(creds.AccessKey, creds.SecretKey)
if err != nil {
return toJSONError(err)
}
reply.Token, err = authenticateWeb(creds.AccessKey, creds.SecretKey)
if err != nil { if err != nil {
return toJSONError(err) return toJSONError(err)
} }

1
cmd/web-handlers_test.go
View File

@ -709,6 +709,7 @@ func testSetAuthWebHandler(obj ObjectLayer, instanceType string, t TestErrHandle
}{ }{
{"", "", "", "", false}, {"", "", "", "", false},
{"1", "1", "1", "1", false}, {"1", "1", "1", "1", false},
{credentials.AccessKey, credentials.SecretKey, "azerty", "bar", false},
{credentials.AccessKey, credentials.SecretKey, "azerty", "foooooooooooooo", true}, {credentials.AccessKey, credentials.SecretKey, "azerty", "foooooooooooooo", true},
} }