MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-01 02:03:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: make sure to purge all the completed in resume() (#18429)

Browse Source 
currently previously completed jobs would re-run
even if they are completed, causing incorrect behavior.
This commit is contained in:
Harshavardhana 2023-11-13 08:15:00 -08:00 committed by GitHub
parent fe63664164
commit 8b1e819bf3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/batch-handlers.go
View File

@ -262,6 +262,9 @@ func (r *BatchJobReplicateV1) StartFromSource(ctx context.Context, api ObjectLay
if err := ri.load(ctx, api, job); err != nil { if err := ri.load(ctx, api, job); err != nil {
return err return err
} }
if ri.Complete {
return nil
}
globalBatchJobsMetrics.save(job.ID, ri) globalBatchJobsMetrics.save(job.ID, ri)
delay := job.Replicate.Flags.Retry.Delay delay := job.Replicate.Flags.Retry.Delay
@ -837,6 +840,9 @@ func (r *BatchJobReplicateV1) Start(ctx context.Context, api ObjectLayer, job Ba
if err := ri.load(ctx, api, job); err != nil { if err := ri.load(ctx, api, job); err != nil {
return err return err
} }
if ri.Complete {
return nil
}
globalBatchJobsMetrics.save(job.ID, ri) globalBatchJobsMetrics.save(job.ID, ri)
lastObject := ri.Object lastObject := ri.Object

3
cmd/batch-rotate.go
View File

@ -261,6 +261,9 @@ func (r *BatchJobKeyRotateV1) Start(ctx context.Context, api ObjectLayer, job Ba
if err := ri.load(ctx, api, job); err != nil { if err := ri.load(ctx, api, job); err != nil {
return err return err
} }
if ri.Complete {
return nil
}
globalBatchJobsMetrics.save(job.ID, ri) globalBatchJobsMetrics.save(job.ID, ri)
lastObject := ri.Object lastObject := ri.Object