MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-06 12:50:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use random file name for write check (#8563)

Browse Source 
Since there may be multiple writes going on concurrently
Use a random file name for the write check to avoid collisions.
This commit is contained in:
Klaus Post 2019-11-22 09:50:17 -08:00 committed by Harshavardhana
parent fb708b6b64
commit 890b493a2e
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/posix.go
View File

@ -19,6 +19,8 @@ package cmd
import ( import (
"bufio" "bufio"
"context" "context"
"crypto/rand"
"encoding/hex"
"errors" "errors"
"io" "io"
"io/ioutil" "io/ioutil"
@ -154,12 +156,15 @@ func getValidPath(path string) (string, error) {
} }
// check if backend is writable. // check if backend is writable.
file, err := os.Create(pathJoin(path, ".writable-check.tmp")) var rnd [8]byte
_, _ = rand.Read(rnd[:])
fn := pathJoin(path, ".writable-check-"+hex.EncodeToString(rnd[:])+".tmp")
file, err := os.Create(fn)
if err != nil { if err != nil {
return path, err return path, err
} }
defer os.Remove(pathJoin(path, ".writable-check.tmp"))
file.Close() file.Close()
os.Remove(fn)
return path, nil return path, nil
} }