MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-07-08 00:22:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: read metadata in O_DIRECT if configured and supported (#11594)

Browse Source 
reduce the page-cache pressure completely by moving
the entire read-phase of our operations to O_DIRECT,
primarily this is going to be very useful for chatty
metadata operations such as listing, scanner, ilm, healing
like operations to avoid filling up the page-cache upon
repeated runs.
This commit is contained in:
Harshavardhana 2021-02-22 01:36:17 -08:00 committed by GitHub
parent 48b212dd8e
commit 8778828a03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/storage-errors.go
View File

@ -143,7 +143,7 @@ func osErrToFileErr(err error) error {
if osIsPermission(err) { if osIsPermission(err) {
return errFileAccessDenied return errFileAccessDenied
} }
if isSysErrNotDir(err) { if isSysErrNotDir(err) || isSysErrIsDir(err) {
return errFileNotFound return errFileNotFound
} }
if isSysErrPathNotFound(err) { if isSysErrPathNotFound(err) {

39
cmd/xl-storage.go
View File

@ -1121,7 +1121,7 @@ func (s *xlStorage) ReadVersion(ctx context.Context, volume, path, versionID str
return fi, nil return fi, nil
} }
func (s *xlStorage) readAllData(volumeDir, filePath string, requireDirectIO bool) (buf []byte, err error) { func (s *xlStorage) readAllData(volumeDir string, filePath string, requireDirectIO bool) (buf []byte, err error) {
var f *os.File var f *os.File
if requireDirectIO { if requireDirectIO {
f, err = disk.OpenFileDirectIO(filePath, os.O_RDONLY, 0666) f, err = disk.OpenFileDirectIO(filePath, os.O_RDONLY, 0666)
@ -1156,7 +1156,7 @@ func (s *xlStorage) readAllData(volumeDir, filePath string, requireDirectIO bool
atomic.AddInt32(&s.activeIOCount, 1) atomic.AddInt32(&s.activeIOCount, 1)
rd := &odirectReader{f, nil, nil, true, true, s, nil} rd := &odirectReader{f, nil, nil, true, true, s, nil}
defer rd.Close() defer rd.Close() // activeIOCount is decremented in Close()
buf, err = ioutil.ReadAll(rd) buf, err = ioutil.ReadAll(rd)
if err != nil { if err != nil {
@ -1172,11 +1172,6 @@ func (s *xlStorage) readAllData(volumeDir, filePath string, requireDirectIO bool
// This API is meant to be used on files which have small memory footprint, do // This API is meant to be used on files which have small memory footprint, do
// not use this on large files as it would cause server to crash. // not use this on large files as it would cause server to crash.
func (s *xlStorage) ReadAll(ctx context.Context, volume string, path string) (buf []byte, err error) { func (s *xlStorage) ReadAll(ctx context.Context, volume string, path string) (buf []byte, err error) {
atomic.AddInt32(&s.activeIOCount, 1)
defer func() {
atomic.AddInt32(&s.activeIOCount, -1)
}()
volumeDir, err := s.getVolDir(volume) volumeDir, err := s.getVolDir(volume)
if err != nil { if err != nil {
return nil, err return nil, err
@ -1188,34 +1183,8 @@ func (s *xlStorage) ReadAll(ctx context.Context, volume string, path string) (bu
return nil, err return nil, err
} }
buf, err = ioutil.ReadFile(filePath) requireDirectIO := globalStorageClass.GetDMA() == storageclass.DMAReadWrite && s.readODirectSupported
if err != nil { return s.readAllData(volumeDir, filePath, requireDirectIO)
if osIsNotExist(err) {
// Check if the object doesn't exist because its bucket
// is missing in order to return the correct error.
_, err = os.Lstat(volumeDir)
if err != nil && osIsNotExist(err) {
return nil, errVolumeNotFound
}
return nil, errFileNotFound
} else if osIsPermission(err) {
return nil, errFileAccessDenied
} else if isSysErrNotDir(err) || isSysErrIsDir(err) {
return nil, errFileNotFound
} else if isSysErrHandleInvalid(err) {
// This case is special and needs to be handled for windows.
return nil, errFileNotFound
} else if isSysErrIO(err) {
return nil, errFaultyDisk
} else if isSysErrTooManyFiles(err) {
return nil, errTooManyOpenFiles
} else if isSysErrInvalidArg(err) {
return nil, errUnsupportedDisk
}
return nil, err
}
return buf, nil
} }
// ReadFile reads exactly len(buf) bytes into buf. It returns the // ReadFile reads exactly len(buf) bytes into buf. It returns the