MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-07-08 16:42:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

Golint cleanup pkg/utils/cpu

Browse Source
This commit is contained in:
Harshavardhana 2015-03-05 19:44:07 -08:00
parent c36450a83a
commit 861f13d5bd
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/utils/cpu/cpu_test.go
View File

@ -32,7 +32,7 @@ type MySuite struct{}
var _ = Suite(&MySuite{}) var _ = Suite(&MySuite{})
func hasCpuFeatureFromOS(feature string) (bool, error) { func hasCPUFeatureFromOS(feature string) (bool, error) {
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {
command := exec.Command("/bin/cat", "/proc/cpuinfo") command := exec.Command("/bin/cat", "/proc/cpuinfo")
output, err := command.Output() output, err := command.Output()
@ -41,9 +41,8 @@ func hasCpuFeatureFromOS(feature string) (bool, error) {
} }
if strings.Contains(string(output), feature) { if strings.Contains(string(output), feature) {
return true, nil return true, nil
} else {
return false, nil
} }
return false, nil
} else { } else {
// TODO find new way to test cpu flags on windows // TODO find new way to test cpu flags on windows
return false, errors.New("Not Implemented on this platform") return false, errors.New("Not Implemented on this platform")
@ -53,7 +52,7 @@ func hasCpuFeatureFromOS(feature string) (bool, error) {
func (s *MySuite) TestHasSSE41(c *C) { func (s *MySuite) TestHasSSE41(c *C) {
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {
var flag = HasSSE41() var flag = HasSSE41()
osCheck, err := hasCpuFeatureFromOS("sse4_1") osCheck, err := hasCPUFeatureFromOS("sse4_1")
c.Assert(err, IsNil) c.Assert(err, IsNil)
c.Check(flag, Equals, osCheck) c.Check(flag, Equals, osCheck)
} }
@ -62,7 +61,7 @@ func (s *MySuite) TestHasSSE41(c *C) {
func (s *MySuite) TestHasAVX(c *C) { func (s *MySuite) TestHasAVX(c *C) {
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {
var flag = HasAVX() var flag = HasAVX()
osFlag, err := hasCpuFeatureFromOS("avx") osFlag, err := hasCPUFeatureFromOS("avx")
c.Assert(err, IsNil) c.Assert(err, IsNil)
c.Check(osFlag, Equals, flag) c.Check(osFlag, Equals, flag)
} }
@ -71,7 +70,7 @@ func (s *MySuite) TestHasAVX(c *C) {
func (s *MySuite) TestHasAVX2(c *C) { func (s *MySuite) TestHasAVX2(c *C) {
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {
var flag = HasAVX2() var flag = HasAVX2()
osFlag, err := hasCpuFeatureFromOS("avx2") osFlag, err := hasCPUFeatureFromOS("avx2")
c.Assert(err, IsNil) c.Assert(err, IsNil)
c.Check(osFlag, Equals, flag) c.Check(osFlag, Equals, flag)
} }