mirror of
https://github.com/minio/minio.git
synced 2025-11-09 13:39:46 -05:00
config: Accept more address format + unit test (#3915)
checkURL() is a generic function to check if a passed address is valid. This commit adds support for addresses like `m1` and `172.16.3.1` which is needed in MySQL and NATS. This commit also adds tests.
This commit is contained in:
committed by
Harshavardhana
parent
f3334159a4
commit
8426cf9aec
12
cmd/utils.go
12
cmd/utils.go
@@ -19,6 +19,7 @@ package cmd
|
||||
import (
|
||||
"encoding/base64"
|
||||
"encoding/xml"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
@@ -263,15 +264,14 @@ func isFile(path string) bool {
|
||||
return false
|
||||
}
|
||||
|
||||
// checkNetURL - checks if passed address correspond
|
||||
// to a network address (and not file system path)
|
||||
func checkNetURL(address string) (*url.URL, error) {
|
||||
// checkURL - checks if passed address correspond
|
||||
func checkURL(address string) (*url.URL, error) {
|
||||
if address == "" {
|
||||
return nil, errors.New("Address cannot be empty")
|
||||
}
|
||||
u, err := url.Parse(address)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("`%s` invalid: %s", address, err.Error())
|
||||
}
|
||||
if u.Host == "" {
|
||||
return nil, fmt.Errorf("`%s` invalid network URL", address)
|
||||
}
|
||||
return u, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user