MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 21:02:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: ignore faulty drives and continue (#10511)

Browse Source 
drives might return different types of errors
handle them individually, and for some errors
just log an error and continue
This commit is contained in:
Harshavardhana
2020-09-18 12:09:05 -07:00
committed by GitHub
parent 1cf322b7d4
commit 7f9498f43f
5 changed files with 45 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/xl-storage_test.go
View File

@@ -453,7 +453,7 @@ func TestXLStorageMakeVol(t *testing.T) {
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}
@@ -552,7 +552,7 @@ func TestXLStorageDeleteVol(t *testing.T) {
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}
@@ -804,7 +804,7 @@ func TestXLStorageXlStorageListDir(t *testing.T) {
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}
@@ -928,7 +928,7 @@ func TestXLStorageDeleteFile(t *testing.T) {
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}
@@ -1126,7 +1126,7 @@ func TestXLStorageReadFile(t *testing.T) {
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}
@@ -1296,7 +1296,7 @@ func TestXLStorageAppendFile(t *testing.T) {
var xlStoragePermStorage StorageAPI
// Initialize xlStorage storage layer for permission denied error.
_, err = newLocalXLStorage(permDeniedDir)
if err != nil && !os.IsPermission(err) {
if err != nil && err != errFileAccessDenied {
t.Fatalf("Unable to initialize xlStorage, %s", err)
}