MyFavMirrors
/
minio
mirror of https://github.com/minio/minio.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

disable builds for go1.18 (#16332)

This commit is contained in:
Harshavardhana 2022-12-30 11:37:07 -08:00 committed by GitHub
parent b67d97b1ba
commit 75faef888e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/go-fips.yml vendored
View File

@ -20,7 +20,7 @@ jobs:
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
strategy: strategy:
matrix: matrix:
go-version: [1.18.5b7] go-version: [1.19.x]
os: [ubuntu-latest] os: [ubuntu-latest]
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v2
@ -30,9 +30,10 @@ jobs:
- name: Setup dockerfile for build test - name: Setup dockerfile for build test
run: | run: |
echo "FROM us-docker.pkg.dev/google.com/api-project-999119582588/go-boringcrypto/golang:${{ matrix.go-version }}" > Dockerfile.fips.test echo "FROM golang:1.19.4" >> Dockerfile.fips.test
echo "COPY . /minio" >> Dockerfile.fips.test echo "COPY . /minio" >> Dockerfile.fips.test
echo "WORKDIR /minio" >> Dockerfile.fips.test echo "WORKDIR /minio" >> Dockerfile.fips.test
echo "ENV GOEXPERIMENT=boringcrypto" >> Dockerfile.fips.test
echo "RUN make" >> Dockerfile.fips.test echo "RUN make" >> Dockerfile.fips.test
- name: Build - name: Build

2
README.md
View File

@ -125,7 +125,7 @@ You can also connect using any S3-compatible tool, such as the MinIO Client `mc`
## Install from Source ## Install from Source
Use the following commands to compile and run a standalone MinIO server from source. Source installation is only intended for developers and advanced users. If you do not have a working Golang environment, please follow [How to install Golang](https://golang.org/doc/install). Minimum version required is [go1.18](https://golang.org/dl/#stable) Use the following commands to compile and run a standalone MinIO server from source. Source installation is only intended for developers and advanced users. If you do not have a working Golang environment, please follow [How to install Golang](https://golang.org/doc/install). Minimum version required is [go1.19](https://golang.org/dl/#stable)
```sh ```sh
go install github.com/minio/minio@latest go install github.com/minio/minio@latest

2
go.mod
View File

@ -1,6 +1,6 @@
module github.com/minio/minio module github.com/minio/minio
go 1.18 go 1.19
require ( require (
cloud.google.com/go/storage v1.28.1 cloud.google.com/go/storage v1.28.1

4
internal/fips/api.go
View File

@ -139,8 +139,8 @@ func TLSCurveIDs() []tls.CurveID {
curves = append(curves, tls.X25519) // Only enable X25519 in non-FIPS mode curves = append(curves, tls.X25519) // Only enable X25519 in non-FIPS mode
} }
curves = append(curves, tls.CurveP256) curves = append(curves, tls.CurveP256)
if go18 { if go19 {
// With go1.18 enable P384, P521 newer constant time implementations. // With go1.19 enable P384, P521 newer constant time implementations.
curves = append(curves, tls.CurveP384, tls.CurveP521) curves = append(curves, tls.CurveP384, tls.CurveP521)
} }
return curves return curves

6
internal/fips/go1.18.go → internal/fips/go19.go
View File

@ -15,9 +15,9 @@
// You should have received a copy of the GNU Affero General Public License // You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>. // along with this program. If not, see <http://www.gnu.org/licenses/>.
//go:build go1.18 //go:build go1.19
// +build go1.18 // +build go1.19
package fips package fips
const go18 = true const go19 = true

6
internal/fips/no_go18.go → internal/fips/no_go19.go
View File

@ -15,9 +15,9 @@
// You should have received a copy of the GNU Affero General Public License // You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>. // along with this program. If not, see <http://www.gnu.org/licenses/>.
//go:build !go1.18 //go:build !go1.19
// +build !go1.18 // +build !go1.19
package fips package fips
const go18 = false const go19 = false