From 749ce107ee485a1853577d0c4142ceb5cefa25c7 Mon Sep 17 00:00:00 2001 From: jiuker <2818723467@qq.com> Date: Wed, 21 Sep 2022 18:08:45 +0800 Subject: [PATCH] fix: context leak with replication endpoint hearbeat (#15721) --- cmd/bucket-targets.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bucket-targets.go b/cmd/bucket-targets.go index e1b5c592c..ed6984f76 100644 --- a/cmd/bucket-targets.go +++ b/cmd/bucket-targets.go @@ -108,7 +108,6 @@ func (sys *BucketTargetSys) heartBeat(ctx context.Context) { if len(eps) > 0 { cctx, cancel := context.WithTimeout(ctx, 30*time.Second) - defer cancel() m := map[string]epHealth{} for result := range sys.hcClient.Alive(cctx, madmin.AliveOpts{}, eps...) { var online bool @@ -121,6 +120,7 @@ func (sys *BucketTargetSys) heartBeat(ctx context.Context) { Online: online, } } + cancel() sys.hMutex.Lock() sys.hc = m sys.hMutex.Unlock()