mirror of
https://github.com/minio/minio.git
synced 2025-11-09 13:39:46 -05:00
Reduce number of envs and options from command line. (#3230)
Ref #3229 After review with @abperiasamy we decided to remove all the unnecessary options - MINIO_BROWSER (Implemented as a security feature but now deemed obsolete since even if blocking access to MINIO_BROWSER, s3 API port is open) - MINIO_CACHE_EXPIRY (Defaults to 72h) - MINIO_MAXCONN (No one used this option and we don't test this) - MINIO_ENABLE_FSMETA (Enable FSMETA all the time) Remove --ignore-disks option - this option was implemented when XL layer would initialize the backend disks and heal them automatically to disallow XL accidentally using the root partition itself this option was introduced. This behavior has been changed XL no longer automatically initializes `format.json` a HEAL is controlled activity, so ignore-disks is not useful anymore. This change also addresses the problems of our documentation going forward and keeps things simple. This patch brings in reduction of options and defaulting them to a valid known inputs. This patch also serves as a guideline of limiting many ways to do the same thing.
This commit is contained in:
@@ -23,56 +23,12 @@ import (
|
||||
"testing"
|
||||
)
|
||||
|
||||
// Tests scenarios which can occur for hasExtendedHeader function.
|
||||
func TestHasExtendedHeader(t *testing.T) {
|
||||
// All test cases concerning hasExtendedHeader function.
|
||||
testCases := []struct {
|
||||
metadata map[string]string
|
||||
has bool
|
||||
}{
|
||||
// Verifies if X-Amz-Meta is present.
|
||||
{
|
||||
metadata: map[string]string{
|
||||
"X-Amz-Meta-1": "value",
|
||||
},
|
||||
has: true || os.Getenv("MINIO_ENABLE_FSMETA") == "1",
|
||||
},
|
||||
// Verifies if X-Minio-Meta is present.
|
||||
{
|
||||
metadata: map[string]string{
|
||||
"X-Minio-Meta-1": "value",
|
||||
},
|
||||
has: true || os.Getenv("MINIO_ENABLE_FSMETA") == "1",
|
||||
},
|
||||
// Verifies if extended header is not present.
|
||||
{
|
||||
metadata: map[string]string{
|
||||
"md5Sum": "value",
|
||||
},
|
||||
has: false || os.Getenv("MINIO_ENABLE_FSMETA") == "1",
|
||||
},
|
||||
// Verifies if extended header is not present, but with an empty input.
|
||||
{
|
||||
metadata: nil,
|
||||
has: false || os.Getenv("MINIO_ENABLE_FSMETA") == "1",
|
||||
},
|
||||
}
|
||||
|
||||
// Validate all test cases.
|
||||
for i, testCase := range testCases {
|
||||
has := hasExtendedHeader(testCase.metadata)
|
||||
if has != testCase.has {
|
||||
t.Fatalf("Test case %d: Expected \"%#v\", but got \"%#v\"", i+1, testCase.has, has)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func initFSObjects(disk string, t *testing.T) (obj ObjectLayer) {
|
||||
endpoints, err := parseStorageEndpoints([]string{disk})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
obj, _, err = initObjectLayer(endpoints, nil)
|
||||
obj, _, err = initObjectLayer(endpoints)
|
||||
if err != nil {
|
||||
t.Fatal("Unexpected err: ", err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user