MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-24 13:13:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: replication of tags while removing (#17989)

Browse Source 
A tag removal was not being replicated prior to this change
This commit is contained in:
Poorna 2023-09-06 19:05:02 -07:00 committed by GitHub
parent f7ca6c63c2
commit 703ed46d79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/bucket-replication.go
View File

@ -702,10 +702,8 @@ func getCopyObjMetadata(oi ObjectInfo, sc string) map[string]string {
meta[xhttp.ContentType] = oi.ContentType meta[xhttp.ContentType] = oi.ContentType
} }
if oi.UserTags != "" { meta[xhttp.AmzObjectTagging] = oi.UserTags
meta[xhttp.AmzObjectTagging] = oi.UserTags meta[xhttp.AmzTagDirective] = "REPLACE"
meta[xhttp.AmzTagDirective] = "REPLACE"
}
if sc == "" { if sc == "" {
sc = oi.StorageClass sc = oi.StorageClass
@ -887,7 +885,7 @@ func getReplicationAction(oi1 ObjectInfo, oi2 minio.ObjectInfo, opType replicati
} }
t, _ := tags.ParseObjectTags(oi1.UserTags) t, _ := tags.ParseObjectTags(oi1.UserTags)
if !reflect.DeepEqual(oi2.UserTags, t.ToMap()) || (oi2.UserTagCount != len(t.ToMap())) { if (oi2.UserTagCount > 0 && !reflect.DeepEqual(oi2.UserTags, t.ToMap())) || (oi2.UserTagCount != len(t.ToMap())) {
return replicateMetadata return replicateMetadata
} }