MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-04 20:00:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: tweak read buffer size to reduce over-reading (#16338)

Browse Source
This commit is contained in:
Klaus Post 2023-01-01 17:14:20 +01:00 committed by GitHub
parent 49b3908635
commit 6a04067514
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/xl-storage.go
View File

@ -1796,15 +1796,9 @@ func (s *xlStorage) ReadFileStream(ctx context.Context, volume, path string, off
} }
or := &xioutil.ODirectReader{ or := &xioutil.ODirectReader{
File: file, File: file,
SmallFile: false, // Select bigger blocks when reading at least 50% of a big block.
} SmallFile: length <= xioutil.BlockSizeLarge/2,
if length <= smallFileThreshold {
or = &xioutil.ODirectReader{
File: file,
SmallFile: true,
}
} }
r := struct { r := struct {

4
internal/ioutil/read_file.go
View File

@ -81,6 +81,10 @@ func ReadFile(name string) ([]byte, error) {
if err != nil { if err != nil {
return io.ReadAll(r) return io.ReadAll(r)
} }
// Select bigger blocks when reading at least 50% of a big block.
r.SmallFile = st.Size() <= BlockSizeLarge/2
dst := make([]byte, st.Size()) dst := make([]byte, st.Size())
_, err = io.ReadFull(r, dst) _, err = io.ReadFull(r, dst)
return dst, err return dst, err