Add constants for commonly used values. (#3588)

This is a consolidation effort, avoiding usage
of naked strings in codebase. Whenever possible
use constants which can be repurposed elsewhere.

This also fixes `goconst ./...` reported issues.
This commit is contained in:
Harshavardhana
2017-01-18 12:24:34 -08:00
committed by GitHub
parent f803bb4b3d
commit 62f8343879
79 changed files with 461 additions and 462 deletions

View File

@@ -38,17 +38,17 @@ func TestSortByHostPath(t *testing.T) {
},
expected: []*url.URL{
{
Scheme: "http",
Scheme: httpScheme,
Host: "abcd.com:9000",
Path: "/a/b/c",
},
{
Scheme: "http",
Scheme: httpScheme,
Host: "abcd.com:9000",
Path: "/a/b/d",
},
{
Scheme: "http",
Scheme: httpScheme,
Host: "abcd.com:9000",
Path: "/a/b/e",
},
@@ -62,17 +62,17 @@ func TestSortByHostPath(t *testing.T) {
},
expected: []*url.URL{
{
Scheme: "http",
Scheme: httpScheme,
Host: "abcd.com:9000",
Path: "/a/b/c",
},
{
Scheme: "http",
Scheme: httpScheme,
Host: "defg.com:9000",
Path: "/a/b/c",
},
{
Scheme: "http",
Scheme: httpScheme,
Host: "hijk.com:9000",
Path: "/a/b/c",
},