mirror of
https://github.com/minio/minio.git
synced 2025-11-20 09:56:07 -05:00
Add constants for commonly used values. (#3588)
This is a consolidation effort, avoiding usage of naked strings in codebase. Whenever possible use constants which can be repurposed elsewhere. This also fixes `goconst ./...` reported issues.
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Minio Cloud Storage, (C) 2015, 2016 Minio, Inc.
|
||||
* Minio Cloud Storage, (C) 2015, 2016, 2017 Minio, Inc.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -153,7 +153,7 @@ func TestInitListeners(t *testing.T) {
|
||||
}
|
||||
}
|
||||
// Windows doesn't have 'localhost' hostname.
|
||||
if runtime.GOOS != "windows" {
|
||||
if runtime.GOOS != globalWindowsOSName {
|
||||
listeners, err := initListeners("localhost:"+getFreePort(), &tls.Config{})
|
||||
if err != nil {
|
||||
t.Fatalf("Test 3: Unable to initialize listeners %s", err)
|
||||
@@ -395,7 +395,7 @@ func TestListenAndServeTLS(t *testing.T) {
|
||||
res, _ := client.Get("http://" + addr)
|
||||
// Without TLS we expect a re-direction from http to https
|
||||
// And also the request is not rejected.
|
||||
if res != nil && res.StatusCode == http.StatusOK && res.Request.URL.Scheme == "https" {
|
||||
if res != nil && res.StatusCode == http.StatusOK && res.Request.URL.Scheme == httpsScheme {
|
||||
okNoTLS = true
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user