MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 12:52:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add constants for commonly used values. (#3588)

Browse Source 
This is a consolidation effort, avoiding usage
of naked strings in codebase. Whenever possible
use constants which can be repurposed elsewhere.

This also fixes `goconst ./...` reported issues.
This commit is contained in:
Harshavardhana
2017-01-18 12:24:34 -08:00
committed by GitHub
parent f803bb4b3d
commit 62f8343879
79 changed files with 461 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/server-main_test.go
View File

@@ -1,5 +1,5 @@
/*
* Minio Cloud Storage, (C) 2016 Minio, Inc.
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -133,7 +133,7 @@ func TestFinalizeAPIEndpoints(t *testing.T) {
// Tests all the expected input disks for function checkSufficientDisks.
func TestCheckSufficientDisks(t *testing.T) {
var xlDisks []string
if runtime.GOOS == "windows" {
if runtime.GOOS == globalWindowsOSName {
xlDisks = []string{
"C:\\mnt\\backend1",
"C:\\mnt\\backend2",
@@ -330,7 +330,7 @@ func TestCheckEndpointsSyntax(t *testing.T) {
"server:/export",
}
if runtime.GOOS == "windows" {
if runtime.GOOS == globalWindowsOSName {
successCases = append(successCases,
`\export`,
`D:\export`,
@@ -401,7 +401,7 @@ func TestIsDistributedSetup(t *testing.T) {
disks []string
result bool
}
if runtime.GOOS == "windows" {
if runtime.GOOS == globalWindowsOSName {
testCases = []struct {
disks []string
result bool
@@ -457,7 +457,7 @@ func TestIsDistributedSetup(t *testing.T) {
func TestInitServerConfig(t *testing.T) {
ctx := &cli.Context{}
root, err := newTestConfig("us-east-1")
root, err := newTestConfig(globalMinioDefaultRegion)
if err != nil {
t.Fatal("Failed to set up test config")
}