MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-09 21:49:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add constants for commonly used values. (#3588)

Browse Source 
This is a consolidation effort, avoiding usage
of naked strings in codebase. Whenever possible
use constants which can be repurposed elsewhere.

This also fixes `goconst ./...` reported issues.
This commit is contained in:
Harshavardhana
2017-01-18 12:24:34 -08:00
committed by GitHub
parent f803bb4b3d
commit 62f8343879
79 changed files with 461 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
cmd/posix_test.go
View File

@@ -1,5 +1,5 @@
/*
* Minio Cloud Storage, (C) 2016 Minio, Inc.
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -286,7 +286,7 @@ func TestPosixMakeVol(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posix, err := newPosix("/usr")
if err != nil {
@@ -377,7 +377,7 @@ func TestPosixDeleteVol(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posixStorage, err = newPosix("/usr")
if err != nil {
@@ -656,7 +656,7 @@ func TestPosixPosixListDir(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posixStorage, err = newPosix("/usr")
if err != nil {
@@ -770,7 +770,7 @@ func TestPosixDeleteFile(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posixStorage, err = newPosix("/usr")
if err != nil {
@@ -881,7 +881,7 @@ func TestPosixReadFile(t *testing.T) {
-1, 5,
nil,
func() error {
if runtime.GOOS == "windows" {
if runtime.GOOS == globalWindowsOSName {
return &os.PathError{
Op: "seek",
Path: preparePath(slashpath.Join(path, "success-vol", "myobject")),
@@ -937,7 +937,7 @@ func TestPosixReadFile(t *testing.T) {
if err != nil && testCase.expectedErr != nil {
// Validate if the type string of the errors are an exact match.
if err.Error() != testCase.expectedErr.Error() {
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
t.Errorf("Case: %d %#v, expected: %s, got: %s", i+1, testCase, testCase.expectedErr, err)
} else {
var resultErrno, expectErrno uintptr
@@ -1075,7 +1075,7 @@ func TestPosixAppendFile(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posixStorage, err = newPosix("/usr")
if err != nil {
@@ -1162,7 +1162,7 @@ func TestPosixPrepareFile(t *testing.T) {
}
// TestPosix for permission denied.
if runtime.GOOS != "windows" {
if runtime.GOOS != globalWindowsOSName {
// Initialize posix storage layer for permission denied error.
posixStorage, err = newPosix("/usr")
if err != nil {