Dont start console service if MINIO_BROWSER=off (#20374)

By default, even if MINIO_BROWSER=off set code tries to get free
port available for the console. 

Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>

cmd/common-main.go

@@ -461,6 +461,7 @@ func handleCommonArgs(ctxt serverCtxt) {
 	certsDir := ctxt.CertsDir
 	certsSet := ctxt.certsDirSet
 
+	if globalBrowserEnabled {
 		if consoleAddr == "" {
 			p, err := xnet.GetFreePort()
 			if err != nil {
@@ -481,6 +482,7 @@ func handleCommonArgs(ctxt serverCtxt) {
 		if consoleAddr == addr {
 			logger.FatalIf(errors.New("--console-address cannot be same as --address"), "Unable to start the server")
 		}
+	}
 
 	globalMinioHost, globalMinioPort = mustSplitHostPort(addr)
 	if globalMinioPort == "0" {
@@ -492,7 +494,9 @@ func handleCommonArgs(ctxt serverCtxt) {
 		globalDynamicAPIPort = true
 	}
 
+	if globalBrowserEnabled {
 		globalMinioConsoleHost, globalMinioConsolePort = mustSplitHostPort(consoleAddr)
+	}
 
 	if globalMinioPort == globalMinioConsolePort {
 		logger.FatalIf(errors.New("--console-address port cannot be same as --address port"), "Unable to start the server")
@@ -696,12 +700,16 @@ func loadEnvVarsFromFiles() {
 	}
 }
 
-func serverHandleEnvVars() {
+func serverHandleEarlyEnvVars() {
 	var err error
 	globalBrowserEnabled, err = config.ParseBool(env.Get(config.EnvBrowser, config.EnableOn))
 	if err != nil {
 		logger.Fatal(config.ErrInvalidBrowserValue(err), "Invalid MINIO_BROWSER value in environment variable")
 	}
+}
+
+func serverHandleEnvVars() {
+	var err error
 	if globalBrowserEnabled {
 		if redirectURL := env.Get(config.EnvBrowserRedirectURL, ""); redirectURL != "" {
 			u, err := xnet.ParseHTTPURL(redirectURL)

cmd/server-main.go

@@ -773,6 +773,9 @@ func serverMain(ctx *cli.Context) {
 	// Always load ENV variables from files first.
 	loadEnvVarsFromFiles()
 
+	// Handle early server environment vars
+	serverHandleEarlyEnvVars()
+
 	// Handle all server command args and build the disks layout
 	bootstrapTrace("serverHandleCmdArgs", func() {
 		err := buildServerCtxt(ctx, &globalServerCtxt)

cmd/signals.go

@@ -81,9 +81,11 @@ func handleSignals() {
 			shutdownLogIf(context.Background(), objAPI.Shutdown(context.Background()))
 		}
 
+		if globalBrowserEnabled {
 			if srv := newConsoleServerFn(); srv != nil {
 				shutdownLogIf(context.Background(), srv.Shutdown())
 			}
+		}
 
 		if globalEventNotifier != nil {
 			globalEventNotifier.RemoveAllBucketTargets()